Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354727

Summary: Duplicated refactoring tests
Product: [Tools] CDT Reporter: Lukas Felber <l.felber>
Component: cdt-refactoringAssignee: Sergey Prigogin <eclipse.sprigogin>
Status: RESOLVED FIXED QA Contact: Sergey Prigogin <eclipse.sprigogin>
Severity: minor    
Priority: P3 CC: cdtdoug
Version: 8.0   
Target Milestone: 8.1.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
fix (removal of duplicate tests) cdtdoug: iplog+

Description Lukas Felber CLA 2011-08-15 08:57:20 EDT 
Build Identifier: I20110613-1736

ExtractFunctionTestSuite contains 7 duplicated tests.

Reproducible: Always

Steps to Reproduce:
duplicates are located (in org.eclipse.cdt.ui.tests/resources/refactoring/ExtractExpression.rts):
 - Extract int constant
 - Extract char constant
 - Extract boolean true constant
 - Extract boolean false constant
 - Extract expresion with typdef Bug 331985
 - Extract macro

and (in org.eclipse.cdt.ui.tests/resources/refactoring/ExtractMethod.rts)
 - Bug 248622: Extract function fails to extract several expressions; Selection at the end
 - Bug 248622: Extract function fails to extract several expressions; Selection in the middle
2.
3.
Comment 1 Lukas Felber CLA 2011-08-15 08:58:25 EDT 
Created attachment 201492 [details]
fix (removal of duplicate tests)

here the fix.
Comment 2 Lukas Felber CLA 2011-08-15 09:00:28 EDT 
(In reply to comment #0)

>  - Extract expresion with typdef Bug 331985

My mistake her. "Extract expresion with typdef Bug 331985" is no duplicate (and also not removed in the patch).
Comment 3 Sergey Prigogin CLA 2011-12-14 15:26:04 EST 
Fixed. Lukas, please verify. Thanks.
Comment 4 CDT Genie CLA 2011-12-14 16:23:03 EST 
*** cdt git genie on behalf of Sergey Prigogin ***

    Bug 354727. Removed duplicated refactoring tests.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=07c85789428dab73bc6f8b8280a10d99560d74fb