Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354647

Summary:	org.eclipse.equinox.p2.user.ui feature has lower version in Indigo SR1 than in Indigo
Product:	[Eclipse Project] Equinox	Reporter:	Tobias Oberlies <t-oberlies>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, kim.moir, tjwatson
Version:	3.7	Flags:	tjwatson: pmc_approved+ john.arthorne: review+
Target Milestone:	3.7.1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Tobias Oberlies

2011-08-12 13:12:58 EDT

The feature org.eclipse.equinox.p2.user.ui has a lower version in the current 3.7.x stream build than in the Indigo release:
Indigo:         2.1.1.v20110526-6-Bg9JXOePwKUTU7X0teV1RtDu-e
M20110810-0800: 2.1.1.R37x_v20110726-1115-6-Bg9JXOePwMUSW9lu0QQ4a2EEi3

With 'R' < 'v', the Indigo version is considered newer. When updating multiple Eclipse platform/Equinox features from Indigo to 3.7.x stream, the "Equinox p2 Provisioning for IDEs" feature is not updated. This typically makes the update fail because of conflicting versions.

The qualifier change when branching off for maintenance is recommended in [1], but I can't find anything mentioning the problem of decreasing versions when changing the qualifier. In fact, if everyone really followed the recommendations (i.e. added 100 for the first change in the master branch after a maintenance branch-off), the qualifier should be changed so that it increases when starting maintenance. Still, all this would require working build avoidance, and this doesn't seem to be in place...

So we just fix it by increasing the one feature version by 0.0.1 in the maintenance branch and 0.0.100 in master?

[1] http://wiki.eclipse.org/Version_Numbering

Comment 1 DJ Houghton

2011-08-15 11:56:41 EDT

Fixed in master:

http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=85a0848fc362e15afdc15a37a7a65aa0c56af49e

Fixed in 3.7.x:

http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?h=R3_7_maintenance&id=753ac03a20395b36083c4c580b25ffb2e7b09cdc

Comment 2 Tobias Oberlies

2011-09-03 06:15:23 EDT

I can confirm that the problem has been fixed for org.eclipse.equinox.p2.user.ui in M20110831-1030.

However the same problem occurs for the three other p2 features:
org.eclipse.equinox.p2.core.feature
org.eclipse.equinox.p2.extras.feature
org.eclipse.equinox.p2.rcp.feature

With 'R' < 'v', these features have a lower version number in M20110831-1030 than in Indigo.

Comment 3 DJ Houghton

2011-09-04 20:46:02 EDT

Kim, shouldn't these errors be picked up as part of the releng tests when the build is being run when we run the comparator against 3.7?

Comment 4 Kim Moir

2011-09-06 10:53:45 EDT

I thought I had updated the builder to compare against 3.7 but in fact it still compares against 3.6.2.  I've opened bug 356822 for this issue and will run a test build for 3.7.x in case there are any problems.

Comment 5 DJ Houghton

2011-09-06 11:54:16 EDT

Thanks Kim. I've updated the core, extras, and rcp features to 1.0.1 in the maintenance build and will keep an eye on the test results once the comparator has been updated.

Comment 6 DJ Houghton

2011-09-06 12:07:17 EDT

http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?h=R3_7_maintenance&id=76e2cf2381c08a60b84d8c522d0c7a6ff48cfe53

Comment 7 Kim Moir

2011-09-09 10:14:32 EDT

It looks like there are still a few warnings

http://download.eclipse.org/eclipse/downloads/drops/M20110908-1333/testresults/versiontool/results.xml

The version of the feature (id: "org.eclipse.equinox.compendium.sdk"; version: "3.7.0.v20110502-7X7XGA3FNKoMz-UVh-nB7ZBJ";  should be at least "3.7.1"."

The version "1.0.100.R37x_v20110726-1115-4-8_9oB5885K5B28WKK" of feature "org.eclipse.equinox.p2.discovery.feature" in feature (id: "org.eclipse.equinox.p2.sdk";version: "3.7.1.R37x_v20110907-9N7sHDNGKQr_bhQlOXRnwJn5DsVZ"; is lower than its version "1.0.100.v20110519-4-8_9oB5885K5B28WKK" in feature (id: "org.eclipse.equinox.p2.sdk";version: "3.7.0.v20110519-9N7sHDJGMMn4xUrxSmFfL7O39XLL"; 

The Version of feature (id: "org.eclipse.equinox.p2.discovery.feature"; version: "1.0.100.R37x_v20110726-1115-4-8_9oB5885K5B28WKK", is lower than the version of feature(id: "org.eclipse.equinox.p2.discovery.feature"; version: "1.0.100.v20110519-4-8_9oB5885K5B28WKK", 

The version of the feature (id: "org.eclipse.equinox.p2.discovery.feature"; version: "1.0.100.R37x_v20110726-1115-4-8_9oB5885K5B28WKK"; should be at least "1.0.100.v20110519-4-8_9oB5885K5B28WKK".

Comment 8 DJ Houghton

2011-09-09 10:40:26 EDT

I've incremented the p2.discovery and compendium.sdk features.

Comment 9 Thomas Watson

2011-09-09 11:51:07 EDT

(In reply to comment #8)
> I've incremented the p2.discovery and compendium.sdk features.

Thanks DJ, +1 to fixing these last issues.