Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354630

Summary: Test failures in R37x builds
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: DJ Houghton <dj.houghton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: 3.7.1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description DJ Houghton CLA 2011-08-12 10:45:33 EDT 
There are some test failures in the latest maintenance build related. The change in bug 348455 has surfaced this problem. We have code in RepositoryAction#setRepositoryCount which is accessing the preference node after it has been removed, thus the error.


java.lang.IllegalStateException: Preference node "http:__eclipse.org_eclipse_updates_RemoveRepositoryActionTest" has been removed.
	at org.eclipse.core.internal.preferences.EclipsePreferences.checkRemoved(EclipsePreferences.java:158)
	at org.eclipse.core.internal.preferences.EclipsePreferences.remove(EclipsePreferences.java:863)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RepositoryAction.setRepositoryCount(RepositoryAction.java:219)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RepositoryAction.removeFromSelf(RepositoryAction.java:174)
	at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.RemoveRepositoryAction.execute(RemoveRepositoryAction.java:38)
	at org.eclipse.equinox.p2.tests.touchpoint.eclipse.RemoveRepositoryActionTest.testInvalidEnablement(RemoveRepositoryActionTest.java:59)
Comment 2 DJ Houghton CLA 2011-08-12 11:23:29 EDT 
.
Comment 3 DJ Houghton CLA 2011-08-12 11:39:02 EDT 
Actually I'm going to change this differently and set the repository count before removing the repository. Reopening to make the change.