Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354496

Summary: migrate jdt.ui to git
Product: [Eclipse Project] JDT Reporter: Kim Moir <kim.moir>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, deepakazad, markus.kell.r, pwebster, remy.suen
Version: 3.8   
Target Milestone: 3.8 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 345669, 345670    
Bug Blocks: 345479    
Attachments:
Description Flags
log from first cvs2git run none

Description Kim Moir CLA 2011-08-11 09:47:57 EDT
This bug is to track the the changes to migrate jdt.ui to git.  As a first step, I'll run a test migration to allow the committers to try out this repo before the real migration.
Comment 1 Dani Megert CLA 2011-08-12 03:18:27 EDT
Is the Releng tool fixed soon? Currently it looks like driving without lights in the night. Not funny ;-).
Comment 2 Kim Moir CLA 2011-08-12 10:30:27 EDT
Created attachment 201401 [details]
log from first cvs2git run

Errors because some files exist in both attic and main branch. 

See http://cvs2svn.tigris.org/faq.html#atticprob

for details.

I'll try to run csv2git again with --retain-conflicting-attic-files  

Dani, let me know if you want me to change the approach to one of the other four options they discuss in the faq.
Comment 3 Kim Moir CLA 2011-08-12 10:41:53 EDT
Dani: Andrew needs some help from a UI perspective to fix the releng tool.  Would you be able to help?  See bug 343320.
Comment 4 Dani Megert CLA 2011-08-12 13:30:51 EDT
(In reply to comment #3)
> Dani: Andrew needs some help from a UI perspective to fix the releng tool. 
> Would you be able to help?  See bug 343320.

Yes, I can help.
Comment 5 Kim Moir CLA 2011-08-14 20:45:41 EDT
Your test repo is ready here
committerid@git.eclipse.org:/gitroot/jdt/eclipse.jdt.ui.git

Please let me know if you find any issues.  Also, let me know when you'd like to schedule the real migration.
Comment 6 Paul Webster CLA 2011-08-14 21:19:29 EDT
(In reply to comment #5)
> Please let me know if you find any issues.  Also, let me know when you'd like
> to schedule the real migration.

the .gitignore has '>' characters in it:
bash$ cat .gitignore
> bin/
> *~
> *.rej
> *.bak
> *.patch
> javacore.*
> heapdump.*
> core.*
> Snap.*
> target/
>
> EOF
Comment 7 Kim Moir CLA 2011-08-15 09:07:18 EDT
I'm running another migration to fix that which hopefully should be available by the end of the day. Running the git filter branch takes 4-6 hours.
Comment 8 Kim Moir CLA 2011-08-15 16:35:18 EDT
Okay, there is a new repo available with the fixed .gitignore
Comment 9 Dani Megert CLA 2011-08-19 04:47:01 EDT
(In reply to comment #8)
> Okay, there is a new repo available with the fixed .gitignore

Didn't look at the repo yet. When doing this we have to verify that all CVS projects with 'eclipse.jdt.ui' ACL are in there.
Comment 10 Dani Megert CLA 2011-08-29 10:24:53 EDT
The following 4 folders in 'eclipse.jdt.ui-home' should be moved together with their history to the 'org.eclipse.jdt.ui' repository as normal top-level projects:

/jdt-ui-home/plugins/
    org.eclipse.jdt.astview
    org.eclipse.jdt.astview.feature
    org.eclipse.jdt.jeview
    org.eclipse.jdt.jeview.feature

==>
org.eclipse.jdt.ui repo
    org.eclipse.jdt.astview
    org.eclipse.jdt.astview.feature
    org.eclipse.jdt.jeview
    org.eclipse.jdt.jeview.feature


The rest of the top-level content looks good. We didn't verify on the file level yet. This is coming soon...
Comment 11 Dani Megert CLA 2011-09-01 10:06:34 EDT
I could not verify the branches as not all branches are created in the CVS repository.

General (E)Git issues:
- Tags which don't exist on all projects are not trustworthy as one only gets the
  correct contents for the files that have that tag in CVS. For the others one 
  gets an approximated content (instead of none like in CVS).
- Text files are checked out with LF delimiter instead of CRLF on my Windows box.
Comment 12 Remy Suen CLA 2011-09-01 10:12:03 EDT
(In reply to comment #11)
> - Text files are checked out with LF delimiter instead of CRLF on my Windows
> box.

May want to check your settings and/or CGit's behaviour. Also see bug 301775.
Comment 13 Dani Megert CLA 2011-09-01 11:05:35 EDT
(In reply to comment #12)
> (In reply to comment #11)
> > - Text files are checked out with LF delimiter instead of CRLF on my Windows
> > box.
> 
> May want to check your settings and/or CGit's behaviour. Also see bug 301775.
CGit? Are you saying it works for you? If so, please tell me the correct settings.
Comment 14 Remy Suen CLA 2011-09-01 13:22:32 EDT
(In reply to comment #13)
> Are you saying it works for you? If so, please tell me the correct
> settings.

We can continue this part of the conversation in bug 355192.
Comment 15 Kim Moir CLA 2011-09-06 09:28:01 EDT
Dani, the jdt.ui git and cvs repositories should now have the tags that will allow you to verify both repositories. I reran the migration.
Comment 16 Dani Megert CLA 2011-09-13 12:12:45 EDT
Looks good except for the changes requested in comment 10.

We are ready to migrate once M2 is finalized.
Comment 17 Kim Moir CLA 2011-09-15 09:20:03 EDT
Dani, regarding comment #10

These projects don't need to have their the preconditioning step run, because these projects weren't part of any SDK builds, is this this correct? The preconditioning step is where we fix up the tags and branches so all bundles are in the maintenance stream for previous 3.x releases.
Comment 18 Dani Megert CLA 2011-09-16 03:06:45 EDT
(In reply to comment #17)
> Dani, regarding comment #10
> 
> These projects don't need to have their the preconditioning step run, because
> these projects weren't part of any SDK builds, is this this correct?
Yes.

> The
> preconditioning step is where we fix up the tags and branches so all bundles
> are in the maintenance stream for previous 3.x releases.
I added a 'Git_migration' tag for our own bookkeeping.
Comment 19 Kim Moir CLA 2011-09-16 10:18:38 EDT
Your repo is ready

kmoir@git.eclipse.org:/gitroot/jdt/eclipse.jdt.ui

I ran the migration yesterday since you said you were ready early.
Comment 20 Markus Keller CLA 2011-09-19 15:33:15 EDT
I've updated the jdtui.map and text.map files for the N-build. I didn't update feature.map, because I didn't want even more risk of screwing the build.

I think we should replace

feature@org.eclipse.jdt=v20110809-0800,:pserver:anonymous@dev.eclipse.org:/cvsroot/eclipse,,org.eclipse.jdt-feature

with 

feature@org.eclipse.jdt=GIT,tag=v20110809-0800,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.git,path=org.eclipse.jdt-feature
Comment 21 Kim Moir CLA 2011-09-20 14:34:20 EDT
Can this bug be closed?  Perhaps the dependent bugs should be added on bug 345479 because the repository is migrated.
Comment 22 Dani Megert CLA 2011-09-21 01:44:19 EDT
(In reply to comment #21)
> Can this bug be closed?
Yes.

> Perhaps the dependent bugs should be added on bug
> 345479 because the repository is migrated.
+1. Verified that this is the case.