Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354484

Summary:	Problem with Undo after executing RenameEClassFeature
Product:	[Modeling] Graphiti	Reporter:	Christian B <buschcobolt>
Component:	Core	Assignee:	Tim Kaiser <tim.kaiser>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.gorning, michael.wenz, tim.kaiser
Version:	0.8.0	Flags:	tim.kaiser: juno+
Target Milestone:	0.9.0
Hardware:	All
OS:	All
Whiteboard:	Juno M1 theme_bugs

Description Christian B

2011-08-11 08:47:47 EDT

Build Identifier: 20110218-0911

In the graphiti tutorial 0.8.0 a RenameEClassFeature is introduced. After renaming an EClass in the Editor and undoing it the Eclass pictogramm element is out of date.

The bug can also be produced with the plugin org.eclipse.grapiti.examples.tutorial (Version 0.8.0.v20110607-1252)

The corresponding forum thread:
http://www.eclipse.org/forums/index.php/mv/msg/234541/714718/#msg_714718

Reproducible: Always

Steps to Reproduce:
1. Open a diagram with type tutorial
2. Create an EClass
3. Rename it by using the custom RenameEClassFeature
4. Undo
BUG: Pictogrammelement of EClass is now out of date

Comment 1 Tim Kaiser

2011-08-11 09:41:05 EDT

I record the following findings:
- if i execute undo two times the rename is undone correctly
- inspecting the command stack i see that
     a) the first command to be undone is an update
     b) the second thing to be undone is the rename

Solution could be to wrap rename and the following update into one compound command.

Comment 2 Tim Kaiser

2011-08-11 10:01:48 EDT

commit 7e7bdaff3bcca7b826d4872b80c4c3fee21c3ea9
Author: tkaiser <tim.kaiser@sap.com> 2011-08-11 15:46:25
Committer: tkaiser <tim.kaiser@sap.com> 2011-08-11 15:46:25
Parent: 1071d2d0f613810d138aceafadce449826a3a229 (test 2)
Branches: master

ASSIGNED - bug 354484: Problem with Undo after executing
RenameEClassFeature 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=354484

Comment 3 Michael Wenz

2012-04-13 03:35:44 EDT

Bookkeeping

Comment 4 Michael Wenz

2012-06-28 10:38:13 EDT

Part of Graphiti 0.9.0 (Eclipse Juno)