| Summary: | [Unit Test Failure] o.e.m.jee.webapp.discoverer.tests.TestNoUri.test001 stays stuck | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] MoDisco | Reporter: | Nicolas Bros <nicolas.bros> | ||||
| Component: | Technologies | Assignee: | Gregoire Dupe <gdupe> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | fabien.giquel, gdupe, modisco.web-inbox | ||||
| Version: | 0.9.0 | Flags: | gdupe:
kepler+
gdupe: luna+ |
||||
| Target Milestone: | 0.13.1 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/49424 https://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=1869d0ac37b71d801abaaf856d38b01ace283641 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Nicolas Bros
Timewise, I think this started happening after the Eclipse file server was replaced. On my PC, the test took 33 seconds. On Hudson, I stopped the build after the test had been running for more than 20 minutes. I suspect a network issue preventing some URLs from being contacted. These URLs are accessed[1] when running this test: http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/ http://www.w3.org/TR/html4/loose.dtd [1] determined using Fiddler Note that these URLs should not be repeatedly accessed through the network according to the W3C, and they block IPs that do this: http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic/ This is probably what happened with build.eclipse.org. I tried on build.eclipse.org: wget http://www.w3.org/TR/html4/loose.dtd The result shows that www.w3.org never returns the resource, and wget keeps retrying: --2011-08-19 04:54:25-- http://www.w3.org/TR/html4/loose.dtd Resolving www.w3.org... 128.30.52.37 Connecting to www.w3.org|128.30.52.37|:80... connected. HTTP request sent, awaiting response... No data received. Retrying. --2011-08-19 04:54:56-- (try: 2) http://www.w3.org/TR/html4/loose.dtd Connecting to www.w3.org|128.30.52.37|:80... connected. HTTP request sent, awaiting response... No data received. Retrying. --2011-08-19 04:55:28-- (try: 3) http://www.w3.org/TR/html4/loose.dtd Connecting to www.w3.org|128.30.52.37|:80... connected. HTTP request sent, awaiting response... No data received. Retrying. ... I think the problem is that "http://java.sun.com/xml/ns/j2ee" is interpreted as an EPackage URI and EMF tries to load it, thereby accessing the network. So, this does not happen as part of the DTD validation or loading an external DTD by the parser (which are both disabled in NoExternalLoadXmlResourceImpl). Created attachment 201791 [details] context stacktrace See the attached stacktrace: this is where the URI "http://java.sun.com/xml/ns/j2ee" is resolved into an EPackage. It seems that call to 'createInputStream("http://java.sun.com/xml/ns/j2ee"
, null);' (in XMLHandlerImpl.getPackageForURI) cannot be avoided for TestNoURI.xml kind of file (without xsi:schema...), even in completing MoDisco URI Handler.
New Gerrit change created: https://git.eclipse.org/r/49424 TestNoUri.test001 looks to work fine I've re-enable it. Gerrit change https://git.eclipse.org/r/49424 was merged to [master]. Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=1869d0ac37b71d801abaaf856d38b01ace283641 Closing. |