| Summary: | Wrong manifest for org.apache.mina.core.source | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Orbit | Reporter: | Gunnar Wagenknecht <gunnar> | ||||
| Component: | bundles | Assignee: | Gunnar Wagenknecht <gunnar> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Lazar Kirchev <l.kirchev> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Fix committed and released. Lazar, please verify. (In reply to comment #1) > Fix committed and released. Lazar, please verify. It's OK. Thanks a lot, Gunnar! I will fix the manifests of all source bundles I have added, since I have left the imports/exports in all of them. I will open a bug for this. But it was not clear from the wiki page for adding source bundles how exactly should the manifest look like. However, I should have checked some other source bundle to see what the manifest should be. Still, probably we should add this to the wiki? (In reply to comment #2) > Still, probably we should add this to the wiki? That's a good idea. Are you volunteering? :) (In reply to comment #3) > (In reply to comment #2) > > Still, probably we should add this to the wiki? > > That's a good idea. Are you volunteering? :) Yes, I will do it. I will edit the page. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Still, probably we should add this to the wiki? > > > > That's a good idea. Are you volunteering? :) > > Yes, I will do it. I will edit the page. I edited the page, http://wiki.eclipse.org/Orbit_Bundle_Checklist#Create_a_Source_Bundle Would you review the change? (In reply to comment #5) > I edited the page, > http://wiki.eclipse.org/Orbit_Bundle_Checklist#Create_a_Source_Bundle Looks good. Thanks! |
Created attachment 201292 [details] patch with corrected source bundle manifest The manifest of org.apache.mina.core.source contains import and export packages header. This is wrong because it does not contain any class files but only Java source files. Usually, the source bundle manifest is very minimal (see the attached patch).