Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354418

Summary:

[Compatibility] Views leak models and managers of tool bars and menus

Product:

[Eclipse Project] Platform

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

major

Priority:

CC:

daniel_megert, emoffatt, pwebster

Version:

4.1

Target Milestone:

4.2 M2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
CompatibilityView patch v1	none

Description Remy Suen

2011-08-10 14:17:28 EDT

In CompatibilityView's createPartControl(*), we link the model and manager with their renderers but this is never cleared. This translates to four leaked objects per disposal, the model and manager of both the tool bar and the part's menu.

Comment 1 Remy Suen

2011-08-15 09:36:59 EDT

Created attachment 201493 [details]
CompatibilityView patch v1

Patch to remove the linking between the renderer and the model when the part is being disposed.

Comment 2 Remy Suen

2011-08-15 09:37:21 EDT

(In reply to comment #1)
> Created attachment 201493 [details]
> CompatibilityView patch v1

Eric, please review for release to 4.1.1, thanks.

Comment 3 Remy Suen

2011-08-29 12:59:34 EDT

Fix pushed to R4_development.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=e924f3fe1177a19777c0964f306e81c2826b19fe

Comment 4 Remy Suen

2011-09-13 08:33:54 EDT

Verified by code inspection with I20110912-0200.