Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354336

Summary:

[oclinecore] OCLinEcore Editor cannot load ecore file

Product:

[Modeling] OCL

Reporter:

Hauke Fuhrmann <haf>

Component:

Core

Assignee:

OCL Inbox <mdt-ocl-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Version:

unspecified

Target Milestone:

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
ecore file that cannot be opened with OCLinEcore editor	none
StackTrace of OCLinEcoreEditor	none

Description Hauke Fuhrmann

2011-08-10 03:49:53 EDT

Build Identifier: 20110615-0604

The attached ecore file cannot be opened in the OCLinEcore editor. Stack Trace attached. Additionally, it cannot be properly used in the CompleteOCLEditor as an import; types from the files cannot be found.

However, the ecore file can be opened correctly in the Sample Ecore Model Editor (Tree Editor), validates correctly and code generation works fine.

So what's wrong with the file?
Other files work fine.

Reproducible: Always

Steps to Reproduce:
1. Import the foo.ecore in a project
2. Open in OCLinEcoreEditor

Comment 1 Hauke Fuhrmann

2011-08-10 03:52:32 EDT

Created attachment 201210 [details]
ecore file that cannot be opened with OCLinEcore editor

Comment 2 Hauke Fuhrmann

2011-08-10 03:54:06 EDT

Created attachment 201211 [details]
StackTrace of OCLinEcoreEditor

Comment 3 Ed Willink

2011-08-10 04:55:37 EDT

Thanks for a good repro. [It's usually worth pasting stack traces inline so that Bugzilla searches for duplicates see the offending class names.]

Problem is that foo::Bar1.start has an EAnnotation with a null source.

Should be a simple fix.

Comment 4 Hauke Fuhrmann

2011-08-10 07:41:56 EDT

Ok, that helped, thanks.

Comment 5 Ed Willink

2011-08-10 14:02:13 EDT

Once the unnamed EAnnotation is fixed, a problem arises with the references

      <eAnnotations references="http://www.eclipse.org/emf/2002/Ecore#//ELong/%http:%2F%2F%2Forg%2Feclipse%2Femf%2Fecore%2Futil%2FExtendedMetaData%"/>

which is a deeply suspect serialization that of course results in an unresolved proxy. This is silently ignored.

Better to ignore than blow up, but it would be good to announce the bad proxies in some popup.

Comment 6 Ed Willink

2011-08-12 11:19:49 EDT

(In reply to comment #5)
> references="http://www.eclipse.org/emf/2002/Ecore#//ELong/%http:%2F%2F%2Forg%2Feclipse%2Femf%2Fecore%2Futil%2FExtendedMetaData%"/>
> 
> which is a deeply suspect serialization 

No it's fine; just looks wierd.

---------------

Annotations may now be unnamed.

The Annotation syntax for references now has a reference keyword; the previous syntax just didn't work. However not all elements can be identified textually so Bug 354621 covers the enhancement to support all references.

The improved code pushed to master for M1 supports the external URI in the example and simple internal named references.

Comment 7 Ed Willink

2013-05-20 11:38:13 EDT

CLOSED after a year in the RESOLVED state.