| Summary: | [windows] Person_me icon in attachments should have transparent background | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sam Davis <sam.davis> | ||||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||||
| Severity: | minor | ||||||||||
| Priority: | P4 | CC: | shawn.minto | ||||||||
| Version: | unspecified | Keywords: | helpwanted | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Davis
Created attachment 201205 [details]
white background
This is how it looks now when there's a blue incoming highlight. It should be transparent so you don't see the white block.
The background is rendered transparently on Gtk at least. Are you on Windows XP? Turns out that I see this as well on win 7. Maybe this is a problem with adding an image to a cell? Can you try converting the image to a PNG? Do you see this in other lists as well, e.g. on the Annotations preferences page? I don't, but that page has a white background anyway, so I wouldn't be able to tell. Note that it's not a problem when you select the item, but only when there is an incoming highlight, so I think it's actually not the image backgroudn that is the problem, but rather that setting the highlight doesn't set the background color on the Label (or whatever contains the image). (I think bug 344770 was the same kind of problem.) Thanks for clarifying. I misinterpreted the highlighting as a selection. Created attachment 201261 [details]
mylyn/context/zip
I still can't reproduce this on Gtk. Can you check if it makes a difference to reorder statements in org.eclipse.mylyn.internal.tasks.ui.editors.AttachmentTableLabelProvider.update(ViewerCell)? I can't find a way to fix this. I can confirm that the image has a transparent color, but it seems it may be an SWT bug (see my context). I even tried messing around with PaintListeners but could not make it work; that may be the way to fix it though. Created attachment 201268 [details]
mylyn/context/zip
Also, all the images that get displayed in that table have the same problem. If you have a small snippet it could be worth filing a bug against SWT. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |