Bugzilla – Full Text Bug Listing
| Summary: | Actions, Handlers and Filters not shown @ Node Level | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Kamesh Sampath <kamesh.sampath> | ||||||||||
| Component: | Sapphire | Assignee: | Konstantin Komissarchik <konstantin> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | kamesh.sampath, konstantin, ling.hao | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | kamesh | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kamesh Sampath
Note that the fix for this should be based on 0.3.x branch rather than HEAD. Right now I am workin on the HEAD how do i switch t 0.3.x branch, when i tried Team ->Swith to another branch or version it not working it says "chosen operation is not enabled" it means I need to make my working copy in fully commited state before I can do that ? I also need a small help, sometimes ite becoming really diffuclt for me to switch back and forth with versions as with my working copy I am not able to commit . Do you have any idea or suggestion to overcome this ? I see lot of eclipse projects are migrating to GIT , are we also planning to do that ? I recommend that you setup a complete new environment for working on different branches. Your dev-eclipse/target need to be from the branch you are working on. At that point, you might as well have separate workspaces instead of trying to switch projects and configuration around. > I also need a small help, sometimes ite becoming really diffuclt for me to > switch back and forth with versions as with my working copy I am not able to > commit . Do you have any idea or suggestion to overcome this ? Once you've exported the patch and attached it to a bug, you can revert your local changes if you need to work on another bug. You can always re-apply the patch when you are ready to resume. > I see lot of eclipse projects are migrating to GIT , are we also planning to > do that ? Git migration will have to happen at some point as that is the direction across Eclipse Foundation, but we have no immediate plans to do that with Sapphire. There have been a lot of pains in adopting Git across Eclipse and frankly I am content to let others work the kinks out. (In reply to comment #3) When I browse the CVS repository i see R_0_3_X, if am not wrong i need to use this source base for this fix. Correct me if I am wrong. Yes, R_0_3_X is the branch to use. (In reply to comment #5) > Yes, R_0_3_X is the branch to use. Can you please change the status to Assigned so that I can work on this bug in parllel to other bugs that I am working on 0_4_x(HEAD) My understanding is that for this change i need to touch only one file DefinitionEditor.sdef. Correct me if am wrong and any other project or file that I might need touch. > My understanding is that for this change i need to touch only one file
> DefinitionEditor.sdef.
Yes, that should be all that's required. There is an existing definition for this triplet that you would need to reference in the right spot in sdef to resolve this.
Great! My Sapphire skills is improving i feel :) yeah in my initial analysis i found the I need to insert ActionsOverallNode - which provides the Actions, Handlers and Filters UI part. Am doing my second part of the analysis where to put insert it mostly here (MasterDetailsContentNodeFactoryCaseDef), let me try to put that right place to make it work and send you a patch for review and merge. Also in this context I would like to provide a small suggestion to improve the documentation, some of the vital things like what is ContentFactoryNode, Content Factory , various presentation hints and how it will be useful and when/where to use. If these can get in much detail on to the document, that will increase the usability of the framework and will lessen your load of some basic questions in the forum which you might need to answer. Please excuse me if these are already addressed am just requoting them :( Created attachment 203103 [details]
Patch v1
this fixes the issues for adding the action parts (actions, handlers, filters etc.,) and content outline node level for the Master Details Editor Page.
Created attachment 203104 [details]
mylyn/context/zip
From my analysis this bug fix is needed only at the places where the content outline node is present typicallu Master Details Page. Let me know if you feel there are other palces where I need to apply this fix, if not please move the bug to next stage. There are two places where this change is needed. You got one of them (under IMasterDetailsContentNodeDef). The other one is under IMasterDetailsContentNodeFactoryCaseDef (which itself is under IMasterDetailsContentNodeFactoryDef). What you have so far will cover statically-defined node. The other construct covers nodes that are dynamically created based on the contents of a list. thanks for pointing and explaining the same . I have made the change and am attaching the new patch for your review and merge. Please review and once you are fine please move the bug to next stage and le me know if I can take the update for this branch. If possible can you pelase put up a small WIKI article on the Sapphire SDEF elements and its usage ? e.g. IMasterDetailsContentNodeDef, IMasterDetailsContentNodeFactoryCaseDef, that will come handy for adopters and later we can merge in to the documentation as that will be very useful for the community. Created attachment 203127 [details]
Patch v2
contains the addition of ActionsOverall Node at the two places wahre its required to be attached
Created attachment 203128 [details]
mylyn/context/zip
Patch committed to 0.3.1 and 0.4 streams. thanks and i see the changes and updated my local R_0_3_x copy. Verify "Actions and Handlers" is added to content outline node, content outline node factory, and case. |