Bugzilla – Full Text Bug Listing
| Summary: | TextView needs a hasFocus() method | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mihai Sucan <mihai.sucan> |
| Component: | Editor | Assignee: | Felipe Heidrich <eclipse.felipe> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse.felipe, mihai.sucan, Silenio_Quarti |
| Version: | unspecified | ||
| Target Milestone: | 0.4 M1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Mihai Sucan
Looks like a good thing to have. at this point, do you only need the method or do you also need events (focusin/focusout)? (In reply to comment #1) > Looks like a good thing to have. > at this point, do you only need the method or do you also need events > (focusin/focusout)? At this point I am not sure if I am going to update Orion in the integration code we have. We aim to land whatever I last pulled from the git repo (on 2011-07-07), which works fine for us. We would like to sync with stable releases once we land. (any comments on stability/regressions? would it be wise/acceptable to update our code? any important fixes?) Wrt. this bug: we need only the hasFocus() method for now, but having events for focusin/focusout would be useful in the future. Thanks for your quick reply! (In reply to comment #2) > (In reply to comment #1) > > Looks like a good thing to have. > > at this point, do you only need the method or do you also need events > > (focusin/focusout)? > At this point I am not sure if I am going to update Orion in the integration > code we have. We aim to land whatever I last pulled from the git repo (on > 2011-07-07), which works fine for us. We would like to sync with stable > releases once we land. (any comments on stability/regressions? would it be > wise/acceptable to update our code? any important fixes?) In all honesty we were not able to do much work in Orion over the last month (most because of all the turmoil caused by eclipse.platform git migration). That said, we are starting on orion again and we will start releasing changes and features soon. > Wrt. this bug: we need only the hasFocus() method for now, but having events > for focusin/focusout would be useful in the future. Do you have the code already ? Did you ever get your commit rights ? (In reply to comment #3) > In all honesty we were not able to do much work in Orion over the last month > (most because of all the turmoil caused by eclipse.platform git migration). > That said, we are starting on orion again and we will start releasing changes > and features soon. Hehe, no worries. > > Wrt. this bug: we need only the hasFocus() method for now, but having events > > for focusin/focusout would be useful in the future. > > Do you have the code already ? Did you ever get your commit rights ? No code. It's trivial, just have to add hasFocus: function () { return this._hasFocus; }. The problem is .. me updating the Orion upstream code. I want to refrain from doing that. I'm very close to landing. Anyway, there's no hurry *at the moment* for this method. I just opened the bug report so we don't forget this. Proposed patch: https://github.com/mihaisucan/orion.client/tree/bug-354270 Please let me know if this needs more changes before the patch can land. Thank you! Fixed http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=075b147ed82cda0b3fa07b147d0a2490b31a403d http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=39186b5f96de90354bc6d66b1201e7ea2f53c152 Note that I renamed the events to FocusIn - Focus FocusOut - Blur and Thank you Mihai for the patch (In reply to comment #7) > and Thank you Mihai for the patch Thank you for landing the patch! Much appreciated! |