Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354223

Summary:	Helgrind doesn't export its package
Product:	[Tools] Linux Tools	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	Valgrind	Assignee:	Daniel Henrique Barboza <danielhb>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	danielhb, ebaron, overholt, wainersm
Version:	0.8.0
Target Milestone:	0.8.1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	344504
Bug Blocks:

Description Martin Oberhuber

2011-08-09 05:11:03 EDT

Build ID: 0.8.0 (Indigo)

As of the Indigo 0.8.0 release, the o.e.linuxtools.valgrind.helgrind MANIFEST.MF does not export its Java package.

In master, the respective export has been added. Could that please be backported to 0.8.1 since we need it for a customization for our product.

The other valgrind tools also export their packages, and in fact exporting packages is considered good practice at Eclipse:
http://wiki.eclipse.org/Export-Package

Comment 1 Andrew Overholt

2011-08-15 09:24:59 EDT

Daniel, can you please supply a patch for this?  Thanks.

Comment 2 Martin Oberhuber

2011-09-07 06:56:38 EDT

It looks like this has been fixed in the stable-0.8 branch on 15-Aug:

http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/valgrind/org.eclipse.linuxtools.valgrind.helgrind/META-INF/MANIFEST.MF?h=stable-0.8&id=352d3ced8833364133f52fc9cdb9352a9a2ce565

So this bug can be closed ... (marking target 0.8.1 for now).

Comment 3 Andrew Overholt

2011-09-07 08:50:06 EDT

Heh, I forgot I fixed this to get the tests to work :)