Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354184

Summary:	context from stack trace population includes irrelevant items
Product:	z_Archived	Reporter:	Sam Davis <sam.davis>
Component:	Mylyn	Assignee:	David Green <greensopinion>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	greensopinion, shawn.minto
Version:	unspecified
Target Milestone:	3.7
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	360161
Bug Blocks:	349624

Description Sam Davis

2011-08-08 16:34:03 EDT

When activating a task with no context, it was prepopulated with classes named Plugin, Product, Severity, and Date, and methods named error, because these words appear somewhere in a comment with a stack trace.

Here's an example stack trace that should cause this problem:

-- Error Details --
Date: Mon Aug 08 14:35:23 CEST 2011
Message: Unhandled event loop exception during blocked modal context.
Severity: Error
Product: Tasktop 2.0.2.qualifier (com.tasktop.ui.application.product)
Plugin: org.eclipse.jface
Session Data:
eclipse.buildId=unknown
java.version=1.6.0_22
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=linux, ARCH=x86, WS=gtk, NL=en_US
Framework arguments:  -product com.tasktop.ui.application.product
Command-line arguments:  -product com.tasktop.ui.application.product -data /home/bmuskalla/.tasktop/workspace -dev file:/projects/tasktop-selfhost/.metadata/.plugins/org.eclipse.pde.core/Tasktop/dev.properties -os linux -ws gtk -arch x86 -consoleLog -console -clean

Exception Stack Trace:

org.eclipse.swt.SWTException: Graphic is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.graphics.Image.getBounds(Image.java:840)
	at org.eclipse.ui.forms.widgets.ImageHyperlink.paintHyperlink(ImageHyperlink.java:108)
	at org.eclipse.ui.forms.widgets.ImageHyperlink.paintHyperlink(ImageHyperlink.java:93)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.paint(AbstractHyperlink.java:296)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink$2.paintControl(AbstractHyperlink.java:84)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:229)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1282)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1267)
	at org.eclipse.swt.widgets.Control.gtk_expose_event(Control.java:2961)
	at org.eclipse.swt.widgets.Composite.gtk_expose_event(Composite.java:701)
	at org.eclipse.swt.widgets.Canvas.gtk_expose_event(Canvas.java:167)
	at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1739)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:5016)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4408)
	at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
	at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:8394)
	at org.eclipse.swt.widgets.Display.eventProc(Display.java:1245)
	at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
	at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2258)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3207)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.block(ModalContext.java:173)
	at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:388)
	at org.eclipse.jface.dialogs.ProgressMonitorDialog.run(ProgressMonitorDialog.java:507)
	at org.eclipse.ui.internal.progress.ProgressMonitorJobsDialog.run(ProgressMonitorJobsDialog.java:275)
	at org.eclipse.ui.internal.progress.ProgressManager$5.run(ProgressManager.java:960)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.progress.ProgressManager.busyCursorWhile(ProgressManager.java:995)
	at org.eclipse.ui.internal.progress.ProgressManager.busyCursorWhile(ProgressManager.java:970)

Comment 1 Steffen Pingel

2011-08-09 05:32:25 EDT

Thanks for the feedback Sam. This should be improved.

Comment 2 David Green

2011-10-03 20:10:24 EDT

This seems to be picking up on elements from the Error Details header.

Created review: http://review.mylyn.org/#change,72

The fix is to ignore class names that are in the default package (ie: a non-empty package name is required).  This helps to avoid false-positives when looking for a stack trace in the description.  Also adds a unit test to verify that it works.

Comment 3 Sam Davis

2011-10-03 21:18:02 EDT

What if the user is actually using the default package? Wouldn't it be better to detect which part of the text is a stack trace (lines that looks something like "at .+\(.+\.java:\d+\)")?

Comment 4 David Green

2011-10-04 00:15:12 EDT

(In reply to comment #3)
> What if the user is actually using the default package? Wouldn't it be better to
> detect which part of the text is a stack trace (lines that looks something like
> "at .+\(.+\.java:\d+\)")?

Stack traces don't always have the word "at" in them, nor do they always have ".java", or even a line number.  It's remarkably difficult to reliably detect all cases.  

Use of the default Java package is discouraged at best, and is not typical of most development projects.  I believe that the current approach is a reasonable compromise.

Comment 5 Steffen Pingel

2011-10-06 15:16:16 EDT

The change looks good to me. Please create a subtask and attach a patch so we can apply it for 3.7. Thanks!

Comment 6 David Green

2011-10-06 15:59:43 EDT

bug 360161 created as a subtask, patch attached.  Not sure why you asked for a subtask?

Comment 7 David Green

2011-10-07 12:23:07 EDT

with bug 360161 resolved, is this still an issue?

Comment 8 Sam Davis

2011-10-07 12:53:29 EDT

That was the only issue I saw.

Comment 9 Steffen Pingel

2011-10-07 13:14:14 EDT

Sorry for making you create another task David. I didn't realize this was already a subtask of bug 349624. On the upside, you get credited twice :).

Comment 10 David Green

2011-10-07 14:59:48 EDT

No problem... always feels good to get double-credit!