Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354170

Summary: There should be a way to turn on/off guides in diagram
Product: z_Archived Reporter: Shenxue Zhou <shenxue.zhou>
Component: SapphireAssignee: Shenxue Zhou <shenxue.zhou>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: konstantin, raj.alagumalai
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Turn on/off guides according to grid visibility none

Description Shenxue Zhou CLA 2011-08-08 13:20:47 EDT 
When dragging nodes around in Sapphire diagram, guides are still visible when the grid is turned off. The guides should only be visible when the grid is visible.
Comment 1 Shenxue Zhou CLA 2011-08-08 13:23:45 EDT 
Created attachment 201095 [details]
Turn on/off guides according to grid visibility
Comment 2 Shenxue Zhou CLA 2011-08-08 13:25:02 EDT 
Fixed.
Comment 3 Konstantin Komissarchik CLA 2011-08-08 13:54:00 EDT 
The alignment guides and the grid are separate features. They should be controlled separately rather than with a single switch.
Comment 4 Shenxue Zhou CLA 2011-08-18 17:57:35 EDT 
Separate the control of guides from the control of grid; created a new diagram action to turn on/off guides.
Comment 5 Raj Alagumalai CLA 2011-08-19 03:37:46 EDT 
verified on 0.3.1.201108181733
Comment 6 Konstantin Komissarchik CLA 2011-08-19 12:04:06 EDT 
I have verified the runtime behavior and that aspect does look good, but some more work is needed on the API and the SDK. In particular...

1. It does not appear that this switch was added the the sdef editor.

2. I would like to follow the api/sdef pattern used for the grid with the guides. Instead of a top-level <show-guides> element, let's use guides/show structure to provide space for any further guides configuration that we may add in the future.
Comment 7 Konstantin Komissarchik CLA 2011-08-19 12:04:19 EDT 
Meant to re-open...
Comment 8 Konstantin Komissarchik CLA 2011-08-19 12:05:33 EDT 
There also needs to be a blurb about this in the 0.3.1 enhancements document...
Comment 9 Shenxue Zhou CLA 2011-08-19 16:56:01 EDT 
Addressed those issues
Comment 10 Konstantin Komissarchik CLA 2011-08-19 19:06:06 EDT 
Verified the resolution of identified items. Closing.