Bugzilla – Full Text Bug Listing
| Summary: | Tooltips do not appear for any Eclipse icons | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Arun Thondapu <arunkumar.thondapu> | ||||
| Component: | SWT | Assignee: | Silenio Quarti <Silenio_Quarti> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | bhunt, bsd, carolynmacleod4, carsten.pfeiffer, daniel_megert, emoffatt, gheorghe, grant_gayed, loskutov, pawel.1.piech, pwebster, remy.suen, Silenio_Quarti, stephan.herrmann, tom.schindl | ||||
| Version: | 4.2 | ||||||
| Target Milestone: | 3.8 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux-GTK | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Arun Thondapu
And I guess it is fine for 3.8M1, correct? (In reply to comment #1) > And I guess it is fine for 3.8M1, correct? Yes it is fine for 3.8 M1. FWIW, tooltips appear with M20110810-2000 on MacOS X. *** Bug 357956 has been marked as a duplicate of this bug. *** Grant seems to think this might be a problem with SWT. Any ideas here? Grant said that the problem doesn't occur in the ControlExample, so I think he's saying that it's not an SWT problem. (At least, SWT's ToolItem.setToolTipText(String) appears to be working properly). Grant and Arun saw it on Linux GTK. I see the problem on Solaris SPARC GTK. It doesn't happen on cocoa or Windows. So it appears to be related to GTK, and it only occurs in e4. Is e4 Eclipse just being a good citizen and calling ToolItem.setToolTipText(String) for each tool item? Or is something else going on, like fake (custom) tooltips made visible on MouseHover or something? Note that on Solaris SPARC, in addition to tooltips not coming up at all, I see some additional weird tooltip behavior: tooltips coming up empty, tooltips flashing endlessly, or flashing once and disappearing... or trying to come up when the mouse crosses the border between tool items, i.e. where MouseLeave or MouseEnter events would occur. Bog heroically says he'll take this one. :) (In reply to comment #6) > Grant said that the problem doesn't occur in the ControlExample, so I think > he's saying that it's not an SWT problem. Grant filed bug 357956 against Platform SWT originally and said "- the same build works fine on 64-bit Cocoa, so I'm assuming it's an swt issue". Although yes, he also said "- these tooltips work fine in the Control Example, so presumably there's something special about the case in e4", so maybe it's a problem on the UI side. > Is e4 Eclipse just being a good citizen and calling > ToolItem.setToolTipText(String) for each tool item? > Or is something else going on, like fake (custom) tooltips made visible on > MouseHover or something? We don't do this although we do call setToolTipText(String) once or twice every second. I don't know if this is an issue or not. Perhaps that explains the flashing behaviour that's exhibited on SPARC. > we do call setToolTipText(String) once or twice every second.
Hee hee - that's hilarious! :)
Any idea why?
(In reply to comment #8) > > we do call setToolTipText(String) once or twice every second. > > Hee hee - that's hilarious! :) > Any idea why? It's what we use right now for making sure the tool items reflect the current state of the application. Paul would know more about this. (In reply to comment #9) > Paul would know more about this. This might be caused by changing IEclipseContext/keybinding active contexts, causing a re-calculation (as the active contexts changed). If that's the case, we probably need a "if getToolTip != newToolTip then setToolTip" PW *** Bug 359830 has been marked as a duplicate of this bug. *** I just realized that the tooltips were in fact appearing if I hover for a long time (a minute or two generally) on the icons. So this seems more like a performance issue now. *** Bug 362425 has been marked as a duplicate of this bug. *** (In reply to comment #12) > I just realized that the tooltips were in fact appearing if I hover for a long > time (a minute or two generally) on the icons. So this seems more like a > performance issue now. Not sure. I've tried to wait but with no result => I can't see any tooltip. I noticed with 4.2M3 that if you start with the leftmost icon on the toolbar (New in my case) and slowly move the mouse to the right, the tooltips will appear. If you mouse hover over a random toolbar icon, the tooltips do not appear. This appears to be the case for views as well as the main toolbar. Also, the problem is not specific to Linux GTK. I'm running on OS X Cocoa 64. *** Bug 364237 has been marked as a duplicate of this bug. *** Comming from bug 364237 two comments: - I didn't expect this bug in the SWT bucket because the same swt versions work just fine in a 3.x setting on the same machine, hm? - Classifying this bug as p3 / major sounds like a big understatement to me. With bugs like this 4.x cannot be perceived as a step forward, I'd say. Paul or Eric or Remy, would you be able to help Bog out by narrowing this down to a JFace snippet, or perhaps try Paul's idea in comment 10? So far, it seems that it is not a Windows problem, but it has been seen on several Linux systems and OS X 64. (In reply to comment #15) > I noticed with 4.2M3 that if you start with the leftmost icon on the toolbar > (New in my case) and slowly move the mouse to the right, the tooltips will > appear. If you mouse hover over a random toolbar icon, the tooltips do not > appear. This appears to be the case for views as well as the main toolbar. Same for me. Calling ToolItem.setEnabled() and ToolItem.setTooltipText() and ToolItem.setText() every half second is causing this problem. I added checks to run away when the values are the the same. Fixed http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=823cc6c2771fef0325da5857f1a25b2b047efde4 (In reply to comment #21) > Fixed > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=823cc6c2771fef0325da5857f1a25b2b047efde4 Shouldn't the target milestone read 4.2 M4 then? Is there any I-build with this fix already that I could try? (In reply to comment #22) > Is there any I-build with this fix already that I could try? Not yet, we usually tend to only have I builds on Tuesdays. This causes SIGSEGV while running our tests. I'll attach the hs_pid file. PW Created attachment 207892 [details]
hs_err_pid24049.log
snippet:
C [libc.so.6+0x7da10] strcmp+0x90
[error occurred during error reporting (printing native stack), id 0xb]
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j org.eclipse.swt.internal.gtk.OS.strcmp(J[B)I+0
j org.eclipse.swt.widgets.Shell.setToolTipText(JJLjava/lang/String;)V+85
j org.eclipse.swt.widgets.Shell.setToolTipText(JLjava/lang/String;)V+4
j org.eclipse.swt.widgets.ToolItem.setToolTipText(Lorg/eclipse/swt/widgets/Shell;Ljava/lang/String;)V+6
j org.eclipse.swt.widgets.ToolItem.setToolTipText(Ljava/lang/String;)V+25
I was able to reproduce this running the UI tests. Fixed in master > 20111205 (In reply to comment #26) > I was able to reproduce this running the UI tests. > > Fixed in master > 20111205 Tooltips are working but the segmentation fault issue is still occurring. I can consistently re-create the crash. The most common crash scenario I have faced is this: On any of the Eclipse views, hover over the close icon to see the tooltip 'Close' appear. Any mouse click anywhere after this sequence causes a crash for me. I tested with 4.2 M4 build id I20111205-1810. (In reply to comment #27) > > I tested with 4.2 M4 build id I20111205-1810. The fix made it into I20111205-2330 PW (In reply to comment #28) > The fix made it into I20111205-2330 Thanks Paul! I can confirm it works well with this build. Sorry for the confusion! |