Bugzilla – Full Text Bug Listing
| Summary: | LinkWithEditorOutlineContribution deregister method is unsafe | ||
|---|---|---|---|
| Product: | [Modeling] TMF | Reporter: | Samantha Chan <chanskw> |
| Component: | Xtext | Assignee: | Jan Koehnlein <jan> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | jan, mkomor, sebastian.zarnekow, tmf.xtext-inbox |
| Version: | 2.0.0 | Flags: | sebastian.zarnekow:
indigo+
|
| Target Milestone: | SR2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
Is it possible to target this for the next 2.0 SR? Thanks! Scheduled for 2.1 Pushed an NPE guard to master. Closing all bugs that were set to RESOLVED before Neon.0 Closing all bugs that were set to RESOLVED before Neon.0 |
I am getting NPE when trying to dispose a customized OutlinePage. The reason is in the deregister method from LinkWithEditorOutlineContribution: @Override public void deregister(OutlinePage outlinePage) { super.deregister(outlinePage); OutlineWithEditorLinker outlineWithEditorLinker = page2linker.remove(outlinePage); outlineWithEditorLinker.deactivate(); getPreferenceStoreAccess().getPreferenceStore().removePropertyChangeListener(outlineWithEditorLinker); } In here, page2linker.remove(...) may return null. You then call outlineWithEditorLinker.deactivate() without checking its return value... and resulted in the NPE.