Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353945

Summary:	AbstractFilterActionContributor not applied after restart
Product:	[Modeling] TMF	Reporter:	Dénes Harmath <thsoft>
Component:	Xtext	Assignee:	Jan Koehnlein <jan>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jan, sebastian.zarnekow, tmf.xtext-inbox
Version:	2.0.1	Flags:	sebastian.zarnekow: indigo+
Target Milestone:	SR2
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Dénes Harmath

2011-08-04 19:35:42 EDT

Build Identifier: I20110613-1736

In Xtext 2.0.1, although AbstractFilterActionContributor reloads its state correctly upon restart, the filter isn't applied.
(Note that this issue remains in spite of https://bugs.eclipse.org/bugs/show_bug.cgi?id=342682 being fixed.)

Reproducible: Always

Steps to Reproduce:
1. Open an Xtext file, and in the Outline, enable Show / Hide terminal rules.
2. Restart Eclipse.
3. Although Show / Hide terminal rules is enabled, terminal rules are still visible.

Comment 1 Dénes Harmath

2011-08-04 19:37:15 EDT

An obvious workaround is to call 

stateChanged(isPropertySet());

in AbstractFilterOutlineContribution#register, but I don't know whether this is the optimal way to do it.

Comment 2 Sebastian Zarnekow

2011-08-16 17:13:21 EDT

Scheduled for 2.1

Comment 3 Jan Koehnlein

2011-10-14 05:58:54 EDT

Refreshing the tree after registering all actions did the job.

Pushed to MASTER.

Comment 4 Karsten Thoms

2017-09-19 17:50:08 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 5 Karsten Thoms

2017-09-19 18:01:05 EDT

Closing all bugs that were set to RESOLVED before Neon.0