Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353882

Summary:	org.eclipse.jst.jsp.core prereq range is too narrow for Juno
Product:	[WebTools] WTP Source Editing	Reporter:	Carl Anderson <ccc>
Component:	jst.jsp	Assignee:	Nick Sandonato <nsand.dev>
Status:	RESOLVED FIXED	QA Contact:	Nick Sandonato <nsand.dev>
Severity:	blocker
Priority:	P3	CC:	david_williams, thatnitind
Version:	3.3
Target Milestone:	3.4 M1
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Carl Anderson

2011-08-04 09:17:02 EDT

In the latest Eclipse 3.8 drivers, the JDT plugin versions have been bumped up to 3.8.0.  Currently, in org.eclipse.jst.jsp.core/META-INF/MANIFEST.MF , it has:

org.eclipse.jdt.core;bundle-version="[3.5.0,3.8.0)",

This causes a build error that states:

Missing required plug-in org.eclipse.jdt.core_[3.5.0,3.8.0).

This range needs to be widened for Juno, and whatever reason that it is this tight of a check needs to be examined.

I am marking this as a blocker, since it is preventing the WTP 3.4.0 build from building.

Comment 1 David Williams

2011-08-04 11:15:42 EDT

I have "blindly" fixed this in HEAD, since many of Source Editing committers are out ... but, suggest we leave this open to be reviewed upon their return. 

In particular, not sure if same change should go in maintenance? Just to keep streams the same? 

I know this was "narrow" for a reason (at one point) since JSP had one or two uses of non-API. 

I did not check if there is any changes in those non-API methods that would impact jsp but seems unlikely (from my memory). 

Team may want to consider alternatives ... using import package? refreshing API request in JDT team? 

And, honestly, as far as I know, maybe they did create API, and there is no reason to be "narrow" any longer?

Comment 2 Nitin Dahyabhai

2011-08-04 13:56:29 EDT

(In reply to comment #1)
> I have "blindly" fixed this in HEAD, since many of Source Editing committers
> are out ... but, suggest we leave this open to be reviewed upon their return. 
> 
> In particular, not sure if same change should go in maintenance? Just to keep
> streams the same? 

3.3 maintenance and HEAD are currently the same for Source Editing, just not the map projects.

Comment 3 Nick Sandonato

2011-08-09 15:30:47 EDT

We don't seem to be using any JDT internals anymore, so I've widened the range up to 4.0.0 exclusive and I've kept this range consistent between 3_3_maintenance and HEAD.