Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353851

Summary: Clean up 'API Errors/Warnings' preference page
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: API ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, Michael_Rennie, pascal, susan
Version: 3.7   
Target Milestone: 3.8 M2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed changes none

Description Dani Megert CLA 2011-08-04 03:13:20 EDT
3.7.

The 'API Errors/Warnings' preference page has several issues:

1. The naming is confusing:
   - the group label talks about "environments"
   - the first sentence talks about "execution descriptions"
   - and then it talks about additional "environment descriptions"
   ==> those are executions environments


2. It says "Additional are available" even if I already installed all of
   them.
   ==> Either we know when all are  installed or we use another label, e.g.:
   "<Install additional execution environments>. I would make that as a link.

3. After clicking the 'install them now' link, the user is lost. He has no
   clue which site to choose and what to select.
   ==> Best would be if we can feed the site plus pre-select the correct IUs.
       If that's not possible, we need to give more hints on the preference
       page itself.

4. The F1 help should have a link to
   http://wiki.eclipse.org/Execution_Environments
Comment 1 Dani Megert CLA 2011-08-04 03:16:41 EDT
Pascal or Susan, can you comment on item 3 i.e. whether it is possible to feed the install wizard with a site and/or the things to pre-select.
Comment 2 Curtis Windatt CLA 2011-08-04 10:05:17 EDT
(In reply to comment #1)
> Pascal or Susan, can you comment on item 3 i.e. whether it is possible to feed
> the install wizard with a site and/or the things to pre-select.

In the Target Platform we have our own implementation of the install dialog and we cannot get the initial selection to work due to the delayed loading of the tree (bug 330715).  I believe there is a bug for pre-selecting an install site as well, but my search didn't find it.
Comment 3 Michael Rennie CLA 2011-08-29 15:36:39 EDT
Created attachment 202358 [details]
proposed changes

The patch aligns the wording on the page. As for the link showing up when you think all EE descriptions are installed - it actually does detect that there are more or not to be installed, but if you use an update site that does not contain them all (that the tooling knows about) the link will show up even though you installed all the ones that were available.

For example I did: 

1. New Eclipse install 
2. install EE descriptions -> installed all of them

Saw the link after restart, and noticed that the update site used by default is for 3.7, which does not contain the JavaSE-1.7 description, once I used a 3.8 update site I could install 1.7 and the link goes away.
Comment 4 Michael Rennie CLA 2011-08-29 16:02:40 EDT
I applied the changes to master, Curtis, Dani, have a look.
Comment 5 Curtis Windatt CLA 2011-08-29 17:20:28 EDT
The fix looks good to me and has been tagged for the I Build.
Comment 6 Dani Megert CLA 2011-09-01 09:40:25 EDT
The F1 help entry is still missing and I'm still lost on the install dialog after pressing the link.
Comment 7 Curtis Windatt CLA 2011-09-08 14:10:58 EDT
(In reply to comment #6)
> The F1 help entry is still missing and I'm still lost on the install dialog
> after pressing the link.

I added a link to the execution environments wiki page, both in the context help and in the actual help page describing each option.  See ref-errorswarnings.htm and api_contextx.xml.

The install dialog problem is bug 304231.
Comment 8 Dani Megert CLA 2011-09-13 04:29:20 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > The F1 help entry is still missing and I'm still lost on the install dialog
> > after pressing the link.
> 
> I added a link to the execution environments wiki page, both in the context
> help and in the actual help page describing each option.  See
> ref-errorswarnings.htm and api_contextx.xml.

So, the final work here is to update the doc (mainly screenshots).
Comment 9 Curtis Windatt CLA 2011-09-13 12:30:43 EDT
> So, the final work here is to update the doc (mainly screenshots).

Thought there already was a bug for this, but I don't see it, so I filed Bug 357517.
Comment 10 Ankur Sharma CLA 2011-09-14 07:17:36 EDT
Verified in I20110913-0200