Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353797

Summary:

isDetach incorrectly assumes oldValues and currentValues are List type

Product:

[Tools] Data Tools

Reporter:

Patrick Casteel <pjcastee>

Component:

Connectivity

Assignee:

Brian Payton <bpayton>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bpayton

Version:

1.9.1

Target Milestone:

1.10

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proprosed fix	bpayton: iplog+

Description Patrick Casteel

2011-08-03 12:59:28 EDT

Build Identifier: 3.4.2

In org.eclipse.datatools.connectivity.sqm.internal.core.rte.fe.GenericDeltaDdlGenerator, isDetach() assumes oldValues and currentValues are List type. This is not a safe assumption since getOldValue returns Object. In the case of DB2 temporal tables, this could return type Table for the historyTable field.

See attached file for modified code.


Reproducible: Always

Steps to Reproduce:
This can only be reproduced currently on an unreleased product.

Comment 1 Patrick Casteel

2011-08-03 13:03:30 EDT

Created attachment 200838 [details]
Proprosed fix

Comment 2 Brian Payton

2012-05-15 21:53:06 EDT

OK, the fix looks good.  I've applied it to DTP 1.10.  Here's the Git commit record:
http://git.eclipse.org/c/datatools/org.eclipse.datatools.connectivity.git/commit/?id=9fbeeeee7a10fbab02b0c98cb2ca455472e9bb1f

Comment 3 Brian Payton

2012-05-15 21:53:56 EDT

Resolving as fixed...