Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353749

Summary:

AbstractOrphanedSessionTest and it's subclasses are running too long

Product:

[RT] Jetty

Reporter:

Thomas Becker <tbecker>

Component:

server

Assignee:

Thomas Becker <tbecker>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

minor

Priority:

CC:

jesse.mcconnell, jetty-inbox, joakim.erdfelt

Version:

7.4.2

Target Milestone:

7.5.x

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
proposed patch	none

Description Thomas Becker

2011-08-03 08:17:56 EDT

Build Identifier: 

The attached patch will reduce the runtime of these tests significantly. As I reduced some timeouts, etc. it's necessary to thoroughly test the patch on all environments (windows, etc.).

Reproducible: Always

Comment 1 Thomas Becker

2011-08-03 08:23:04 EDT

Created attachment 200806 [details]
proposed patch

As requested no change to VERSION.txt. Feel free to use the commit message for VERSION.txt:

+ 353749: OrphanedSessionTests runtime reduced

Comment 2 Jesse McConnell

2011-08-03 09:12:57 EDT

this fails on jdbc tests on my machine, better to switch to a latching mechanism or something

Comment 3 Greg Wilkins

2011-08-29 01:13:37 EDT

Using latches or exchanges rather than shorter timeouts is a better way to reduce test times without risking failures.

Comment 4 Joakim Erdfelt

2011-09-15 17:23:46 EDT

Current timings for the session tests are...

Running org.eclipse.jetty.server.session.ClientCrossContextSessionTest : 0.39 sec
Running org.eclipse.jetty.server.session.LightLoadTest : 0.002 sec
Running org.eclipse.jetty.server.session.NewSessionTest : 7.636 sec
Running org.eclipse.jetty.server.session.ReentrantRequestSessionTest : 0.195 sec
Running org.eclipse.jetty.server.session.OrphanedSessionTest : 9.215 sec
Running org.eclipse.jetty.server.session.ServerCrossContextSessionTest : 0.14 sec
Running org.eclipse.jetty.server.session.RemoveSessionTest : 0.138 sec

Comment 5 Thomas Becker

2011-09-23 07:15:17 EDT

Won't spend any more time on this to save a couple of seconds only.