Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353638

Summary:	Confusing "none" option in required element property presentation
Product:	z_Archived	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Sapphire	Assignee:	Konstantin Komissarchik <konstantin>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ling.hao
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Shenxue Zhou

2011-08-02 15:41:18 EDT

Sapphire UI renders Element property using radio buttons by default. Each radio button represents a specific element type. It also renders a "None" radio button to indicate the property has not been set. This could be confusing to user since he/she might think "None" is also a valid option. For element property with @Required annotation, before the property is set, the None radio button would be selected with red "x" in front of it. This would add to user confusion.

The agreed approach to solve this issue is to not render None radio button but keep the red "x"/"light bulb" in front of the None radio button for element property with @Required annotation. The red "x"/"light bulb" would be used to indicate validation errors or to clear user selection.

More info could be found at http://dev.eclipse.org/mhonarc/lists/sapphire-dev/msg00464.html

Comment 1 Konstantin Komissarchik

2011-09-14 10:00:52 EDT

There is insufficient time remaining to tackle something this extensive. We will pick this up for the 0.4 release.

Comment 2 Konstantin Komissarchik

2013-10-22 18:13:58 EDT

0.7 : http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=ad88b1354093c04e7c2a08808c72b9650f9dc2ef

The radio button group presentation of the with part renderes a radio button for each possible child type along with a "None" radio button.  The none choice is confusing, especially when the element property is required. This presentation is also inconsistent with the radio button group presentation used for enum value properties.

The solution is to move the none option to the end and only show it when
the property is empty. If necessary, user can clear the property using
the provided field assist action.

A similar issue exists in the pop-up list presentation of the with part.

The solution is to align with the presentation used for value properties with possible values, where the pop-up list selection is cleared to indicate that the property is empty rather than using a deadicated none list item.

Comment 3 Ling Hao

2013-10-30 11:55:43 EDT

Verified "none" radio button was shown only as necessary and displayed at the end in sapphire-sample.xml. Verified pop up list presentation in OEPE. Closing.