Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353605

Summary:

Add support for merging and fixing up RangeLists and fix empty RangeList bug

Product:

[Tools] CDT

Reporter:

Daniel Thomas <daniel.thomas>

Component:

cdt-debug-edc

Assignee:

Ken Ryall <ken.ryall>

Status:

RESOLVED WONTFIX

QA Contact:

Ken Ryall <ken.ryall>

Severity:

normal

Priority:

CC:

cdtdoug, kirk.beitz

Version:

8.0

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Add support for rangelist merging, fixing up and not returning empty rangelists	none
Better patch which only upates rangelist using children also updating start and end addresses	none
Patch to add proper merging support, tests on this, use it and bug fixes	none

Description Daniel Thomas

2011-08-02 11:30:49 EDT

Build Identifier: 

There were TODOs in Scope asking for the implementation of proper merging which is now done.

fixupRanges in Scope only fixed high and low addresses and took no account of the ranges of the children it is fixing up.

DwarfInfoReader would return empty RangeLists when null is the canonical form for an empty range list.

Reproducible: Always

Comment 1 Daniel Thomas

2011-08-02 11:31:28 EDT

Created attachment 200731 [details]
Add support for rangelist merging, fixing up and not returning empty rangelists

Comment 2 Daniel Thomas

2011-08-02 11:37:50 EDT

Created attachment 200733 [details]
Better patch which only upates rangelist using children also updating start and end addresses

Comment 3 Daniel Thomas

2011-08-04 05:46:46 EDT

Created attachment 200895 [details]
Patch to add proper merging support, tests on this, use it and bug fixes

This patch first adds support for proper merging of IRangeLists (as a static method in RangeList this time as that is a better location)
Then it adds tests to check that this and other RangeList functionality works, in the process a bug in the isInRange function was found and fixed.
Then it uses this rangelist merging functionality to make fixupRanges fixup the range lists as well as the start and end addresses.
Then fix a bug in DwarfInfoReader where it would return a non-null RangeList which was empty rather than returning null (which means empty in the RangeList context).

Comment 4 Kirk Beitz

2011-08-06 16:39:30 EDT

i've moved the TestRangeList part of the patch to org.eclipse.cdt.debug.edc.tests.

with that change, the patch has been merged and nominally tested in our local source base. waiting for final review and merge to eclipse edc git repository by
committer Ken Ryall.

Comment 5 Jonah Graham

2019-12-30 18:40:08 EST

(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/