Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353599

Summary: ArrayType does not generate its name using its bounds
Product: [Tools] CDT Reporter: Daniel Thomas <daniel.thomas>
Component: cdt-debug-edcAssignee: Ken Ryall <ken.ryall>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: trivial    
Priority: P3 CC: cdtdoug, kirk.beitz
Version: 8.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to add support for generating the ArrayType name
none
Add a test that checks this behaviour
none
Patch to add support for generating the ArrayType name
cdtdoug: iplog+
Add tests on ArrayType generally cdtdoug: iplog+

Description Daniel Thomas CLA 2011-08-02 10:41:45 EDT
Build Identifier: 

An array int[4][5] should have the name "int[4][5]" rather than "int[]", "int" or "int[4]" and I have a patch which adds support for correctly generating the name of the ArrayType.

Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-08-02 10:42:13 EDT
Created attachment 200724 [details]
Patch to add support for generating the ArrayType name
Comment 2 Daniel Thomas CLA 2011-08-04 07:56:16 EDT
Created attachment 200908 [details]
Add a test that checks this behaviour
Comment 3 Daniel Thomas CLA 2011-08-05 06:59:57 EDT
Created attachment 200967 [details]
Patch to add support for generating the ArrayType name

Previous patch had a broken import.
Comment 4 Daniel Thomas CLA 2011-08-05 07:00:59 EDT
Created attachment 200968 [details]
Add tests on ArrayType generally

Also tests changes in: https://bugs.eclipse.org/bugs/show_bug.cgi?id=353611
Comment 5 Kirk Beitz CLA 2011-08-05 21:01:27 EDT
the patch has been merged and nominally tested in our local source base.

the test case has been added instead to
org.eclipse.cdt.debug.edc.tests.ArrayBoundsTest
rather than as a separate regression test.

both are waiting for final review and merge to eclipse edc git repository by
committer Ken Ryall.
Comment 6 Kirk Beitz CLA 2011-08-06 16:34:36 EDT
(In reply to comment #5)
> the test case has been added instead to
> org.eclipse.cdt.debug.edc.tests.ArrayBoundsTest
> rather than as a separate regression test.

as per patch for another Array type issue, this test is now part of org.eclipse.cdt.debug.edc.tests.TestArrayType