Bugzilla – Full Text Bug Listing
| Summary: | [Global Actions] missing icon in File / Refresh menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Adam Kiezun <akiezun> | ||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | minor | ||||||
| Priority: | P5 | CC: | pwebster, remy.suen | ||||
| Version: | 2.1 | Keywords: | helpwanted | ||||
| Target Milestone: | 3.4 M3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 2000 | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 204135 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Adam Kiezun
Should use same icon as Navigator. Is this still a problem in 3.3? PW Changes requested on bug 193523 The action is being created by the ActionFactory so using the org.eclipse.ui.commandImages extension point doesn't seem to cut it (unless I'm using it incorrectly). Paul, do we need to change this to a handler first? The image is also in org.eclipse.ui.ide, so we'd need to copy/paste it to org.eclipse.ui and/or org.eclipse.ui.workbench. Probably the most correct option would be to turn ActionFactory.REFRESH into a WorkbenchCommandAction Then copy the icon to org.eclipse.ui and add it as a commandImages extension. Then we need to make sure there's a default path through WorkbenchCommandAction and super-classes that uses the ICommandImageService if no image was set through the IAction interface. PW Created attachment 78853 [details]
Patch to change the ActionFactory class to create WorkbenchCommandAction.
This patch updates the ActionFactory class and includes the updated diff for the commandImages extension in the plugin.xml as well as the refresh_nav.gif image.
Released to HEAD >20070925 PW In I20071030-0010 PW |