Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353433

Summary:

Copy Details - URL should falls back to connector.getTaskUrl if no taskUrl in ITask

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

steffen.pingel

Version:

unspecified

Keywords:

contributed

Target Milestone:

3.7

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
changed file	none
mylyn/context/zip	none
patch v1	none
patch v2	steffen.pingel: iplog+
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2011-07-29 12:17:38 EDT

Seems odd that even though this API exists, if a connector doesn't set the taskUrl in the ITask, copyURL wont work, but open in browser will.

Comment 1 Thomas Ehrnhoefer

2011-07-29 13:08:32 EDT

Created attachment 200610 [details]
changed file

Suggested changes.
Sorry Steffen, I have no clue how I can actually get you a patch with git

Comment 2 Thomas Ehrnhoefer

2011-07-29 13:08:38 EDT

Created attachment 200611 [details]
mylyn/context/zip

Comment 3 Steffen Pingel

2011-08-11 09:55:33 EDT

Thomas, to create a patch, please commit locally and then follow these steps: http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches

Comment 4 Thomas Ehrnhoefer

2011-08-11 10:21:10 EDT

Created attachment 201316 [details]
patch v1

Comment 5 Steffen Pingel

2011-08-12 08:40:00 EDT

This looks good. I am happy to apply if you could make the following changes: rename getTaskUrl() to getUrl(), add an @author tag for yourself and add a test case to CopyDetailsActionTest. Thanks!

Comment 6 Thomas Ehrnhoefer

2011-11-25 14:14:27 EST

Created attachment 207553 [details]
patch v2

Comment 7 Thomas Ehrnhoefer

2011-11-25 14:14:30 EST

Created attachment 207554 [details]
mylyn/context/zip

Comment 8 Steffen Pingel

2011-11-27 14:01:59 EST

Thanks! I have applied the patch.