Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353295

Summary: Upgrade javax.servlet.jsp.jstl to v1.2 tag
Product: [RT] Gemini.Web Reporter: Glyn Normington <glyn.normington>
Component: unknownAssignee: Glyn Normington <glyn.normington>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 2.0.0.RC1   
Target Milestone: 2.0.0.RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
jstl 1.2 API JAR downloaded from jstl.java.net
none
jstl 1.2 implementation JAR downloaded from jstl.java.net none

Description Glyn Normington CLA 2011-07-28 05:28:53 EDT 
The aim is to fix the issue in CQ 4354, namely that it is not possible to locate the source of the bundle in the project's subversion repository.

For simplicity, both API and implementation will be packaged in a single bundle, following the decision to do that in the current version of the bundle.
Comment 1 Glyn Normington CLA 2011-07-28 06:06:57 EDT 
Created attachment 200512 [details]
jstl 1.2 API JAR downloaded from jstl.java.net
Comment 2 Glyn Normington CLA 2011-07-28 06:08:06 EDT 
Created attachment 200513 [details]
jstl 1.2 implementation JAR downloaded from jstl.java.net
Comment 3 Glyn Normington CLA 2011-07-28 06:12:18 EDT 
Downloaded the JSTL 1.2 API and implementation JARs from http://jstl.java.net/download.html and attached them to this bug.

Combined these JARs, minus Maven directories, and created a single bundle in the SpringSource Enterprise Bundle Repository under EBR commit 395bbce2a3384f78d5ebe7b1872f8c4d34cdc156.

Obtained the corresponding source code from the 1.2 tag of the subversion repository https://svn.java.net/svn/jstl~svn and included this in the above EBR commit.

The new bundle version number is 1.2.0.v20110728.
Comment 4 Glyn Normington CLA 2011-07-28 06:46:41 EDT 
Upgraded the Gemini Web dependency:

~/eclipse/virgo/org.eclipse.virgo.web-server/scripts/update-dependency.rb -v javax.servlet.jstl -n 1.2.0.v20110728

and then built and published:

ant clean-ivy clean clean-integration test package publish -Declipse.committerId=gnormington

(TomcatServletContainerTests needed to be updated to use the new version).

Pushed the Gemini Web changes in commit 255f789ec3be28daf96e36fc52304432ec5b33e3.

This was published as version 2.0.0.BUILD-20110728103513.
Comment 5 Glyn Normington CLA 2011-07-28 08:35:11 EDT 
Upgraded the Virgo Web Integration Layer dependencies:

~/eclipse/virgo/org.eclipse.virgo.web-server/scripts/update-dependency.rb -v org.eclipse.gemini.web -n 2.0.0.BUILD-20110728103513

~/eclipse/virgo/org.eclipse.virgo.web-server/scripts/update-dependency.rb -v javax.servlet.jsp.jstl -n 1.2.0.v20110728

Note that the variable name in Virgo web's build.versions is javax.servlet.jsp.jstl whereas in Gemini Web it was javax.servlet.jstl.

Built and tested:

ant clean-ivy clean clean-integration test

Rippled and pushed.
Comment 6 Glyn Normington CLA 2011-07-28 08:47:18 EDT 
Updated CQ 4354: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4354#c20