Bug 353239

Description Felipe Heidrich 2011-07-27 13:52:24 EDT

Access a bug that has a patch
try https://bugs.eclipse.org/bugs/show_bug.cgi?id=345411
note that there is a patch in comment 1, click on it
it will open the patch in the compare view.
Now I want to apply this patch to eclipse, click in the Raw Unified 
Select all the text, copy it the clipboard

In eclipse, select the project and in the context menu use  Team->Apply Patch
In the first page select: Clipboard
Press Finish

Get an error: Clipboard does not contain a valid patch.

Go back to the browser,
The URL points to:
https://bugs.eclipse.org/bugs/attachment.cgi?id=195537&action=diff&context=patch&collapsed=&headers=1&format=raw
The content is:
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java,v
--- Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java
		1.122
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java
	
@@ -387,7 +387,7 @@ 
 					TCHAR buffer = new TCHAR (parent.getCodePage (), string, false);
 					int flags = OS.DT_NOPREFIX | OS.DT_SINGLELINE | OS.DT_CALCRECT;
 					OS.DrawText (hDC, buffer, buffer.length (), textRect, flags);
-					rect.right += textRect.right - textRect.left + Table.INSET * 3 + 1;
+					rect.right += textRect.right - textRect.left + Table.INSET * 3 + 2;
 				}
 			}
 		}




--------------
Edit the URL to: https://bugs.eclipse.org/bugs/attachment.cgi?id=195537
(removing all the  &action=diff&context=patch&collapsed=&headers=1&format=raw)
Now the content is:

### Eclipse Workspace Patch 1.0
#P org.eclipse.swt
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java,v
retrieving revision 1.122
diff -u -r1.122 TableItem.java
--- Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java	31 May 2010 16:44:10 -0000	1.122
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java	12 May 2011 19:45:36 -0000
@@ -387,7 +387,7 @@
 					TCHAR buffer = new TCHAR (parent.getCodePage (), string, false);
 					int flags = OS.DT_NOPREFIX | OS.DT_SINGLELINE | OS.DT_CALCRECT;
 					OS.DrawText (hDC, buffer, buffer.length (), textRect, flags);
-					rect.right += textRect.right - textRect.left + Table.INSET * 3 + 1;
+					rect.right += textRect.right - textRect.left + Table.INSET * 3 + 2;
 				}
 			}
 		}


Go back to Eclipse is follow the same steps as before, all works fine.


It would be good if "Raw Unified" would just spit the content the way Eclipse likes it.