Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353228

Summary: [Import/Export] "Import an archive" dialog is not reliably picking up a pasted archive location
Product: [Eclipse Project] Platform Reporter: Helmut J. Haigermoser <helmut.haigermoser>
Component: IDEAssignee: Dani Megert <daniel_megert>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, daniel_megert, mober.at+eclipse
Version: 2.0   
Target Milestone: 3.8 M6   
Hardware: All   
OS: All   
Whiteboard:

Description Helmut J. Haigermoser CLA 2011-07-27 11:58:28 EDT
Build Identifier: 3.7

On my Red Hat Linux 5.4 I'm having trouble using the "Import" > "Archive file" wizard. 
The combo "From archive file" can be filled via the "Browse.." button, which works like a charm. However, copy/pasting a fully qualified file name into the combobox directly does not seem to work, tabbing out after the paste operation leaves the header at "Source must not be empty". Note that the paste method I use is middle-mouse button, no keyboard event is involved in that.

Note that copy/pasting does work sometimes, but only if I enter the combobox, Ctrl-V'ing does the trick, or delete/adding a character. 



Reproducible: Always

Steps to Reproduce:
1. Open the "Import Archive file" wizard
2. Select something outside eclipse
3. Middle-mouse-paste into the combobox
4. Tab out of there
Comment 1 Helmut J. Haigermoser CLA 2011-07-27 11:59:33 EDT
CQ:WIND00224625
Setting the version to 3.7
Comment 2 Dani Megert CLA 2011-07-28 03:22:40 EDT
I can easily reproduce this on Windows 7 too by replacing step 3 with:
3. right click in the field to open the context menu > Paste

This looks like a general flaw in the import/export dialog fields: pasting via mouse doesn't seem to set the dirty flag and hence no validation takes place.
Comment 3 Helmut J. Haigermoser CLA 2011-07-28 04:00:42 EDT
(In reply to comment #2)
> I can easily reproduce this on Windows 7 too by replacing step 3 with:
> 3. right click in the field to open the context menu > Paste
> 
> This looks like a general flaw in the import/export dialog fields: pasting via
> mouse doesn't seem to set the dirty flag and hence no validation takes place.

Thanks Daniel, the scope of the bug is definitely important to get right!:)
So, how are our chances for getting a fix to this, other dialogs seem to behave correctly in this scenario, maybe it's as easy as changing a base import/export class?
Helmut
Comment 4 Dani Megert CLA 2011-07-28 05:04:34 EDT
I can take a look but not for 3.7.1 as this is broken since 2.0.
Comment 5 Helmut J. Haigermoser CLA 2011-07-28 05:12:37 EDT
(In reply to comment #4)
> I can take a look but not for 3.7.1 as this is broken since 2.0.

Thanks Daniel, I appreciate your effort in this !:) Let me know if you need any verification help or something! :)
Helmut
Comment 6 Martin Oberhuber CLA 2012-01-23 11:52:16 EST
(In reply to comment #4)
> I can take a look but not for 3.7.1 as this is broken since 2.0.

Hi Dani, what's life like ... do you have any cycles towards 4.2 ?
Comment 7 Dani Megert CLA 2012-01-23 11:55:58 EST
(In reply to comment #6)
> (In reply to comment #4)
> > I can take a look but not for 3.7.1 as this is broken since 2.0.
> 
> Hi Dani, what's life like ... do you have any cycles towards 4.2 ?

It still has the '3.8' target, so there's hope ;-).
Comment 8 Dani Megert CLA 2012-01-30 04:58:27 EST
Fixed in R3_development: f08a2d551319a70e45fdda4273644e0a5e9f7b77
Fixed in master: 4627dd95c0eda50d91a9129d78a9e0d9e49a68b6
Comment 9 Curtis Windatt CLA 2012-03-13 12:51:30 EDT
I have never used the middle mouse paste feature before. I probably won't again after this :)  Verified in:

Version: 3.8.0
Build id: I20120312-1800
and
Version: 4.2.0
Build id: I20120313-0610