Bugzilla – Full Text Bug Listing
| Summary: | Selection of specific resources to commit fails if selected resource is not already "added" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Rob Stryker <stryker> | ||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||
| Status: | NEW --- | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | adietish, remy.suen | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Updating version info. I am using version Eclipse EGit - Source 1.0.0.201106090707-r org.eclipse.egit.source.feature.group Eclipse EGit I would also like to note that your target versions are in complete disarray here in bugzilla and in discernable order ;) 0.6.0-M1 0.6.0-M2 0.6.0-M3 0.7.0 0.8.0 1.0.0 0.9.0 0.9.0-M3 0.9.0-M2 0.9.0-M1 0.10.0-M1 0.10.0-M2 0.10.0-M3 0.10.0-M1 etc etc etc Created attachment 200416 [details]
Ensure selected IFile objects are force-selected
Howdy all: Is there anything I can do to have this bug / patch investigated? It's been sitting here for months. Anything at all? Do I just assign it to someone? To who? Should I set a target milestone? I'm not sure if I know enough about the product to decide the proper milestone for release. (In reply to comment #3) > Is there anything I can do to have this bug / patch investigated? It's probably better to get your change set pushed to Gerrit. this patch is now obsolete. The current commit dialog behaves in the way this issue suggests. You'd have to enable it in the preferences though: Check the checkbox at preferences->git->commit dialog->"Include selected untracked files". |
In a project that is fully committed, I make two changes: 1) Change index.html 2) Add a new file blah.txt I then select both index.html and blah.txt, right-click, and select commit. In the ensuing dialog, *ONLY* index.html is selected. Blah.txt is ignored because it has not been previously added to the repository. The offending code is in CommitDialog.createDialogArea when deciding which of the pre-selection candidates are acceptable. A conscious decision was made to ignore those that are not added already (such as .project, etc) when selecting a folder, however the use-case where specifically-selected files are not pre-selected. && item.status != Status.UNTRACKED && item.status != Status.ASSUME_UNCHANGED) Patch to be attached to force IFile selections to be pre-selected whether they are already added to the repo or not.