Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353151

Summary: NPE thrown after using the link in the Git commit selection dialog
Product: [Technology] EGit Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Kevin Sawicki <kevin>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Remy Suen CLA 2011-07-26 14:49:52 EDT
1. Click on the 'Open Git Commit...' in the toolbar.
2. Click on the 'Search repositories for commits...' link.
3. Click 'Cancel'.
4. An NPE is thrown.

Caused by: java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.commit.OpenCommitAction.run(OpenCommitAction.java:32)
	at org.eclipse.ui.actions.ActionDelegate.runWithEvent(ActionDelegate.java:70)
	at org.eclipse.ui.internal.handlers.ActionDelegateHandlerProxy.execute(ActionDelegateHandlerProxy.java:281)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
	at java.lang.reflect.Method.invoke(Method.java:600)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
	... 34 more
Comment 1 Kevin Sawicki CLA 2011-07-26 16:22:30 EDT
Proposed fix pushed to: http://egit.eclipse.org/r/#change,3922
Comment 2 Benjamin Muskalla CLA 2011-07-26 18:48:01 EDT
Merged as bfecbe84cdd975c90e9d088d6b76d199af7694f7. Thanks Kevin.