Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353147

Summary: Memory Leak: Actions holding editor selection references after edtior closes
Product: [Technology] EGit Reporter: Thomas Fletcher <tfletche>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: angvoz.dev, malaperle, remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
YourKit memory reference screenshot none

Description Thomas Fletcher CLA 2011-07-26 14:19:45 EDT 
Doing some memory leak profiling on our application that has a custom editor, we have found that a git action is not properly clearing its selection after an editor is closed.

Profiled using YourKit profiler (www.yourkit.com)
* Open an editor
* Close an editor
- Run the GC and take a memory snapshot and there are still references held by the git actions:
Comment 1 Thomas Fletcher CLA 2011-07-26 14:20:43 EDT 
Created attachment 200387 [details]
YourKit memory reference screenshot

Attached a screenshot of the result in YourKit.
Comment 2 Remy Suen CLA 2011-07-27 10:00:35 EDT 
Also see bug 352282 and bug 352743.
Comment 3 Remy Suen CLA 2011-08-16 07:39:12 EDT 
Looking at the code, I would expect the leak to be constant, where the number of leaked editors is always one (or perhaps one per workbench window). Is this correct?