Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353120

Summary: Git status is broken if user.name and user.email are not in the repo configuration
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: GitAssignee: Tomasz Zarna <tomasz.zarna>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: janikpiotrek, libingw
Version: 0.2   
Target Milestone: 0.3 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard: gsoc2011
Bug Depends on: 350422    
Bug Blocks:    
Attachments:
Description Flags
Broken Git Status page none

Description Szymon Brandys CLA 2011-07-26 10:35:09 EDT
For repos without user.name and user.email in the configuration Git Status page does not work. The workaround is to add these props to the configuration.
Comment 1 Szymon Brandys CLA 2011-07-26 10:36:15 EDT
Created attachment 200362 [details]
Broken Git Status page
Comment 2 Piotr Janik CLA 2011-07-26 13:34:20 EDT
https://github.com/pjanik/orion.client/tree/bug353120
I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 3 Tomasz Zarna CLA 2011-07-28 07:29:29 EDT
Can you extract these lines into a function, to reduce code duplication?

			that._userEmail = configEntry.Value;
			that._processCloneInfo();
			that._processStatus();
			
Other then that, looks good.
Comment 4 Piotr Janik CLA 2011-07-28 07:38:02 EDT
Updated, available at github.