Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353077

Summary:

Disabling notifications does not work

Product:

z_Archived

Reporter:

Jesper Eskilson <jesper.eskilson>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

torkildr

Version:

unspecified

Target Milestone:

3.6.2

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Notification preferences	none
mylyn/context/zip	none

Description Jesper Eskilson

2011-07-26 03:33:12 EDT

Build Identifier:  I20110613-1736

It is not possible to disable build notifications.

Reproducible: Always

Steps to Reproduce:
1. Open Window > Preferences > Mylyn > Notifications
2. Uncheck notifiers (all or only some)
3. Click OK
4. Restart
5. View is still displaying "Hudson Server Discovery" for servers on my network which I haven't added (and that I don't want to add).

Comment 1 Jesper Eskilson

2011-07-26 03:35:26 EDT

Alternative reproduction:

...
4. Reopen preference window
5. Observe that the notifications are still active.

Comment 2 Steffen Pingel

2011-07-26 14:35:34 EDT

This appears to work for me. Which version of Mylyn are you using?

Comment 3 Jesper Eskilson

2011-07-27 02:51:50 EDT

Copied from the "Installation Details":

  Mylyn Builds (Incubation)	0.8.0.v20110608-1400	org.eclipse.mylyn.builds.feature.group	Eclipse Mylyn

Comment 4 Steffen Pingel

2011-07-27 06:36:58 EDT

Thanks, that looks good. What is the version of the org.eclipse.mylyn.commons.notifications plug-in on your system?

Comment 5 Jesper Eskilson

2011-07-27 07:17:37 EDT

org.eclipse.mylyn.commons.notifications also has version 0.8.0.v20110608-1400.

Comment 6 Torkild Resheim

2011-08-04 04:34:47 EDT

Created attachment 200884 [details]
Notification preferences

Works nicely for me too. However there appears to be a problem with the preference dialog. As you can see from the screenshot the "Builds view" is checked while the "Build Service Changes" item indicates that no notifiers are checked.

Comment 7 Steffen Pingel

2011-08-27 12:30:44 EDT

I found several problems that were causing the described problems. Enablement state is now consistently determined by the selected flag in NotificationAction. I deprecated the selected flag in NotifcationEvent and will remove that from the extension point.

Additionally, I fixed a condition that caused changes in the preference page to not get persisted to disk. This fix addresses the originally reported problem.

Jesper, as a work around: Start Eclipse without the Builds view visible, then go to Preferences > Mylyn > Notifications and make the desired choices. You can verify that the expected state is getting persisted in <workspace>/.metadata/.plugins/org.eclipse.mylyn.commons.notifications/notifications.xml. If you now open the Builds view your notification preferences should get respected.

I have pushed a fix to master and the e_3_7_m_3_6_x branch: 19b5ab998c85a453072fa795714715f855496b89.

Comment 8 Steffen Pingel

2011-08-27 12:30:48 EDT

Created attachment 202268 [details]
mylyn/context/zip