Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 353057

Summary: EMFSynchronizationContentProvider should provide children
Product: [Modeling] EMFCompare Reporter: Benjamin Muskalla <b.muskalla>
Component: TeamAssignee: EMF Compare <emf.compare-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: laurent.goubet
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
screenshot none

Description Benjamin Muskalla CLA 2011-07-25 20:52:35 EDT 
EMFSynchronizationContentProvider uses an AdapterFactoryContentProvider as a delegate content provider.
But it seems no children can be obtained for a tree (eg. selection adjustments for logical models)
Comment 1 Benjamin Muskalla CLA 2011-07-25 20:53:02 EDT 
Created attachment 200321 [details]
screenshot

Screenshot showing no children
Comment 2 Laurent Goubet CLA 2011-07-26 03:25:53 EDT 
Benjamin,

I haven't observed this bug with the tests I did on CVS, could you provide us with the steps to reproduce? I haven't yet checked out your code for the git integration :).
Comment 3 Benjamin Muskalla CLA 2011-07-26 07:40:56 EDT 
With the patched EGit, have two models files, one referencing the other, hit commit on the one with the reference.

Do you have some example files in CVS to compare the behavior?
Comment 4 Laurent Goubet CLA 2011-07-26 08:08:12 EDT 
I have tested this just this morning on CVS, without reproducing. I will check out your current work on the eGit implementation of the logical resources; the content provider may not be fed the same "parent" from which to retrieve elements.
Comment 5 Benjamin Muskalla CLA 2011-07-26 08:10:16 EDT 
As far as I can see, the object for which the children should be retrieved is a @ResourceSetImpl@
Comment 6 Laurent Goubet CLA 2011-07-26 08:18:02 EDT 
(whoops)

When trying to debug the content provider to check the "parent" element ... I noticed that yes, I do reproduce with CVS (angel).

I wasn't looking at the right dialog. In the "selection adjustment required" dialog, I indeed don't have children for the "EMF Compare" root ... I wonder if I should really be showing that root there altogether.
Comment 7 Benjamin Muskalla CLA 2011-07-26 08:28:53 EDT 
Hm...yeah, wondering about that too given that we only care about file levels here. I think it would be ok to omit the node at all.
Comment 8 Laurent Goubet CLA 2013-01-11 11:07:58 EST 
The "EMF Compare" root will not be displayed with EMF Compare 2 comparisons, and logical model support as a whole should be greatly enhanced by both the compare and EGit team's enhancements.

No particular effort will be made for EMF Compare 1 on that issue.