Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352999

Summary: ExpireTest running too long
Product: [RT] Jetty Reporter: Thomas Becker <tbecker>
Component: clientAssignee: Jan Bartel <janb>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jesse.mcconnell, jetty-inbox
Version: 7.4.2   
Target Milestone: 7.5.x   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
proposed patch none

Description Thomas Becker CLA 2011-07-25 08:30:35 EDT 
Build Identifier: 

This test sends 200 client requests to the server. To verify that the onExpire method is being called the only handler is just waiting for 2000ms and a countDownlatch is counted down in the onExpire method.

After sending each requests the test waits for 50ms. To me there's no obvious reason to wait, so I removed the Thread.sleep call. 

Reduced the testrun from >10s to <1s.

Reproducible: Always
Comment 1 Thomas Becker CLA 2011-07-25 08:32:46 EDT 
Created attachment 200274 [details]
proposed patch
Comment 2 Jesse McConnell CLA 2011-08-02 09:05:02 EDT 
- Log -----------------------------------------------------------------
commit cd0dd3e8ffd34d80b4d614c8d05c1687eae7d5bd
Author: Jesse McConnell <jesse.mcconnell@gmail.com>
Date:   Tue Aug 2 08:04:18 2011 -0500

   [Bug 352999] test performance patch applied to jetty-client, thanks Thomas

-----------------------------------------------------------------------

Summary of changes:
 VERSION.txt                                        |    1 +
 .../java/org/eclipse/jetty/client/ExpireTest.java  |    2 --
 2 files changed, 1 insertions(+), 2 deletions(-)