Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352905

Summary: [Compatibility] 'Quick Outline' disappears if opened after opening an editor
Product: [Eclipse Project] Platform Reporter: Brian de Alwis <bsd>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: major    
Priority: P3 CC: daniel_megert, emoffatt, remy.suen
Version: 4.1   
Target Milestone: 4.1.1   
Hardware: All   
OS: All   
Whiteboard:

Description Brian de Alwis CLA 2011-07-22 15:32:56 EDT 
I frequently do the following actions when browsing code:
  1. F3 or Ctrl-Shift-T to open a class declaration
  2. ^O to bring up a quick outline
  3. <type chars> to bring up a particular method

With 3.x I could do these actions quickly without waiting for the editor to open.

With 4.x somehow the Quick Outline disappears and the characters I type type over the class name.

In fact I find that I really need to pause and wait between steps (1) and (2).  Otherwise it will seem to work (that is, the editor will open and the Quick Outline window pops up), but before I can type in any characters the Quick Outline window will disappear.

I mentioned this to Remy on IRC, and he suspected the following:

[13:51:10] <rcjsuen> I just tried that but looks like F3 took so long the Ctrl+O and the characters did nothing
[14:21:53] <briandealwis> rcjsuen: Oops, sorry, got distracted.  Did the ^O come up with the your characters?  Or were the characters put into the editor instead?
[14:28:49] <rcjsuen> briandealwis: no in this case Ctrl+O didn't happen
[14:28:55] <rcjsuen> i think it got eaten while the progress dialog was up (processing F3)
Comment 1 Dani Megert CLA 2011-07-25 03:55:43 EDT 
I can reproduce the same on Windows 7. It looks like the the focus is stolen again asynchronously from the Quick Outline. This also affects any other action that takes focus, e.g. opening Find/Replace (Ctrl+F) is not working if invoked directly after opening a resource.

This should be fixed for 4.1.1.
Comment 2 Remy Suen CLA 2011-07-25 10:49:43 EDT 
What is the easiest way to reproduce this problem? I don't think I'm doing this right.

If I open a file and then immediately hit Ctrl+F and start typing, the text goes inside the editor even on 3.x.
Comment 3 Dani Megert CLA 2011-07-25 10:54:29 EDT 
(In reply to comment #2)
> What is the easiest way to reproduce this problem? I don't think I'm doing this
> right.
> 
> If I open a file and then immediately hit Ctrl+F and start typing, the text
> goes inside the editor even on 3.x.

Strange. I see this too if I open a *.java file. But if I open a *.txt file I get the Find/Replace dialog and then it types in there.

Try using Open Type and then Ctrl+O.
Comment 4 Dani Megert CLA 2011-07-26 09:49:10 EDT 
Eric, can this be targeted for 4.1.1?
Comment 5 Remy Suen CLA 2011-07-26 10:51:20 EDT 
(In reply to comment #1)
> I can reproduce the same on Windows 7. It looks like the the focus is stolen
> again asynchronously from the Quick Outline.

Okay, I think I'm starting to see this.

After 'Open Type' and then using Ctrl+O and spamming the keyboard, the file opens and the outline shows up briefly while taking input but it suddenly disappears shortly after and the spammed input starts going inside the editor, correct?
Comment 6 Dani Megert CLA 2011-07-26 10:52:46 EDT 
(In reply to comment #5)
> (In reply to comment #1)
> > I can reproduce the same on Windows 7. It looks like the the focus is stolen
> > again asynchronously from the Quick Outline.
> 
> Okay, I think I'm starting to see this.
> 
> After 'Open Type' and then using Ctrl+O and spamming the keyboard, the file
> opens and the outline shows up briefly while taking input but it suddenly
> disappears shortly after and the spammed input starts going inside the editor,
> correct?

Yep.
Comment 7 Dani Megert CLA 2011-07-26 10:53:28 EDT 
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #1)
> > > I can reproduce the same on Windows 7. It looks like the the focus is stolen
> > > again asynchronously from the Quick Outline.
> > 
> > Okay, I think I'm starting to see this.
> > 
> > After 'Open Type' and then using Ctrl+O and spamming the keyboard, the file
> > opens and the outline shows up briefly while taking input but it suddenly
> > disappears shortly after and the spammed input starts going inside the editor,
> > correct?
> 
> Yep.

And if you don't type anything except Ctrl+O, you at least loose the Ctrl+O as the Outline immediately closes.
Comment 8 Remy Suen CLA 2011-07-26 12:34:09 EDT 
*** Bug 352149 has been marked as a duplicate of this bug. ***
Comment 9 Remy Suen CLA 2011-07-26 12:53:03 EDT 
Upon further investigation this bug is a manifestation of the same problem described by bug 352149. After the editor is opened the stack renderer captures the request to activate the tab folder (in the shared area) an enqueues an asynchronous request activate its selected part. The keybinding is filtered through and the dialog is opened, correctly taking in input from the keyboard. The asynchronous request is processed later and the activation of the part causes the dialog to be deactivated (and closed).
Comment 11 Remy Suen CLA 2011-08-09 14:08:52 EDT 
*** Bug 345946 has been marked as a duplicate of this bug. ***
Comment 12 Brian de Alwis CLA 2011-08-11 09:45:14 EDT 
Problem solved for me.  Thanks Remy!
Comment 13 Remy Suen CLA 2011-08-11 09:53:22 EDT 
(In reply to comment #12)
> Problem solved for me.  Thanks Remy!

Also verified on my end with I20110809-2000 on Windows XP. Thanks for checking, Brian.