Bugzilla – Full Text Bug Listing
| Summary: | Add two new "done" methods to RequestMonitor and DataRequestMonitor | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Eugene Ostroukhov <eostroukhov> | ||||||||
| Component: | cdt-debug-dsf | Assignee: | Marc Khouzam <marc.khouzam> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Pawel Piech <pawel.1.piech> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | cdtdoug, marc.khouzam | ||||||||
| Version: | 8.0 | Flags: | marc.khouzam:
review?
(pawel.1.piech) |
||||||||
| Target Milestone: | 8.1.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
I like it. +1 I don't see why not. Although, I don't think it'll really help much in avoiding the debug session from hell async programming syndrome :-( Eugene, can you confirm: 1- you wrote 100% of the code 2- you have the right to contribute the code to Eclipse Also, can you add a line to the top of the file, under Contributors saying: Eugene Ostroukhov (<company name if any>) - New Done method. Bug 352888. Thanks 1. Yes. 2. Do I need some paperwork from my employer? I recall there was something for a committer but I don't know if it is same for single patch. I can't find a page that would describe this process. (In reply to comment #4) > 1. Yes. > 2. Do I need some paperwork from my employer? I recall there was something for > a committer but I don't know if it is same for single patch. I can't find a > page that would describe this process. I believe that going through bugzilla for a patch less than 250 lines is enough: http://www.eclipse.org/projects/dev_process/ip-process-in-cartoons.php http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf Created attachment 201942 [details]
Suggested changes (v2)
Attached is a patch with contributor info.
1. This patch was created entirely by me.
2. I have a permision from management to contribute this patch to Eclipse CDT project.
Created attachment 202454 [details]
Patch to commit
This is the patch I will commit.
1- It has the changes from Eugene: "Suggested changes (v2)".
2- It ups the org.eclipse.cdt.dsf plugin version to 2.3.0
3- It adds the @since tags
4- It makes use of the two new done(...) methods in JUnit tests to have them tested regularly.
I'll commit to master.
Committed. Pawel, can you review? Thanks Eugene for the contribution. *** cdt git genie on behalf of Eugene Ostroukhov ***
Bug 352888: Add two new "done" methods to RequestMonitor and DataRequestMonitor
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=97d0869a9a9c5f10a9e52dcdf7dfd5b2b115a023
|
Created attachment 200216 [details] Suggested changes (v1) I have been building DSF-based debugger for weeks now but I still forget to call done() method after setData/setStatus. Usually this results in a debug session from hell so I would like to suggest adding two new done methods that will combine setStatus/setData and done call. This is a trivial change that does not require any changes in the existing client code.