Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352832

Summary: CommitIntegrityCheck doesn't treat CDOIDNull as Java NULL value with CDOSetFeatureDelta
Product: [Modeling] EMF Reporter: Egidijus Vaisnora <vaisegid>
Component: cdo.coreAssignee: Egidijus Vaisnora <vaisegid>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 CC: saulius.tvarijonas
Version: 4.1Flags: stepper: review+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Test case
none
Patch
none
Patch v2 none

Description Egidijus Vaisnora CLA 2011-07-22 04:10:04 EDT 
Checking should work when local revision cache is not update from the revisions on server. After revision is serialized from server simple Java NULL value is replaced into CDOID.NULL. CommitIntegrityCheck treats this CDOID.NULL in CDOSetFeatureDelta as failure. 
It looks weird to have two kind of NULL values and definitely it will lead to bugs over and over, but it different story.
Comment 1 Egidijus Vaisnora CLA 2011-07-22 04:11:32 EDT 
Created attachment 200157 [details]
Test case
Comment 2 Egidijus Vaisnora CLA 2011-07-22 04:17:02 EDT 
Created attachment 200158 [details]
Patch
Comment 3 Eike Stepper CLA 2011-09-19 03:25:50 EDT 
Created attachment 203569 [details]
Patch v2

I changed the check slightly and added the test case to AllConfigs.java
Comment 4 Eike Stepper CLA 2011-09-19 03:28:02 EDT 
Please backport to 4.0 in bug 358062.
Comment 5 Egidijus Vaisnora CLA 2011-09-19 04:14:41 EDT 
Committed to trunk, revision 9175
Comment 6 Eike Stepper CLA 2012-09-21 07:18:15 EDT 
Closing.