Bugzilla – Full Text Bug Listing
| Summary: | Use size property to compute value string | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] DLTK | Reporter: | Julien Desgats <jdesgats> | ||||
| Component: | Common-Debug | Assignee: | dltk.common-inbox <dltk.common-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | andrei.sobolev, andrey, contact | ||||
| Version: | 3.0 | Keywords: | contributed | ||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 365334 | ||||||
| Attachments: |
|
||||||
Ping :) Any chance you guys could review and include the attached patch? Pong :) Reviewing... Patch are applied to HEAD. Thanks. |
Created attachment 200154 [details] Use IIndexedValue.getSize() when possible to get size Currently, the org.eclipse.dltk.debug.core.model.CollectionScriptType.formatValue use IScriptValue.getVariables().length to get the children count. This can lead to useless property_get commands in case of the children of the value has not been retrieved yet. The proposed patch use IIndexedValue.getSize() (which is a basic getter) if possible.