Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352822

Summary:

CellEditor EEnum is not available for FacetAttribute

Product:

z_Archived

Reporter:

Vincent Lorenzo <vincent.lorenzo>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

emft.facet-inbox, gdupe, nicolas.bros

Version:

unspecified

Flags:

gdupe: indigo+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

354218

Bug Blocks:

Attachments:

Description	Flags
This patch allows to affect the EEnum Editor for the AttributeFacetColumn	nicolas.bros: iplog+, nicolas.bros: review+

Description Vincent Lorenzo

2011-07-22 03:11:25 EDT

When we create a FacetAttribute which type is EEnum, there is not CellEditor for this attribute.

Comment 1 Vincent Lorenzo

2011-07-22 04:08:43 EDT

Created attachment 200156 [details]
This patch allows to affect the EEnum Editor for the AttributeFacetColumn

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 2 Nicolas Bros

2011-08-09 09:07:48 EDT

Comment on attachment 200156 [details]
This patch allows to affect the EEnum Editor for the AttributeFacetColumn

I committed the patch in revision 735 (with an additional case to handle non-enum facet attributes).
And I added UI tests (Bug352822Test) that check that both simple facet attributes and facet attributes of type enum are editable.

This is a small patch (< 200 lines). The
contribution does not need a CQ.

Comment 3 Nicolas Bros

2011-08-09 09:25:13 EDT

The SWTBot tests don't pass on Hudson, likely because of Bug 261360 (context menus are broken in SWTBot).
I'll try to find a workaround.

Comment 4 Nicolas Bros

2011-08-12 12:08:04 EDT

After fighting many hours with SWTBot, the tests finally pass on Hudson.
So I'm marking this bug as fixed.

Comment 5 Gregoire Dupe

2012-05-23 06:37:15 EDT

Hello Vincent,

Please, can you close this bug, if your problem has been solved ?

Regards,
Grégoire

Comment 6 Gregoire Dupe

2012-05-23 12:31:20 EDT

Sorry Vincent, but this bug has to be closed for the IP log generation.