Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352808

Summary:	Editing the configuration area location doesn't mark the launch configuration as changed
Product:	[Eclipse Project] PDE	Reporter:	Eric Jain <eric.jain>
Component:	UI	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, ivanla, jeffrey.kilgore, rhuddusa, tgdahle, tjwatson
Version:	3.7	Keywords:	helpwanted
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	309701
Bug Blocks:	356853, 362945

Description Eric Jain

2011-07-21 18:59:38 EDT

Build Identifier: 20110615-0604

When I edit the configuration area location of an "Eclipse Application" launch configuration, the launch configuration is not marked as dirty. So unless I do another change to the launch configuration, the Apply button remains inactive, and the change is lost when I switch to another launch configuration or close the dialog.

Reproducible: Always

Comment 1 Curtis Windatt

2011-07-25 15:30:44 EDT

This is a regression caused by bug 309701.

Fix will be to modify the performApply() method.  However, we will want to avoid reintroducing any problems.  Fix should be backported to 3.7.x.

Comment 2 Ivan Larionov

2011-08-09 03:50:27 EDT

Additionally, if even I managed to make 'Apply' button appear enabled the configuration area location would still be unchanged next time I open this configuration. Thus, it is impossible now to change it to the one different from the default one.

Comment 3 Jeff Kilgore

2011-10-04 10:32:08 EDT

Is there a workaround we can use to get around this?  (i.e., manually changing the location in a configuration file)

Comment 4 Curtis Windatt

2011-10-05 16:33:39 EDT

If you save your launch configuration to the workspace (see the common tab), you can modify the configuration area property "configLocation".

Comment 5 Curtis Windatt

2011-11-04 15:36:55 EDT

Fixed in master.

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3c8b8ad36762f2efc95070079b0421118b542b76

Updates the config area immediately if default and config name changes. Stores the last user edited area and restores if you toggle the default button. This is an improvement on the fix in 309701 as it stores the correct value the first time instead of just suppressing the change until the next time the config was edited.

Since this regression exists in 3.7, I will clone this bug to backport the fix.

Comment 6 Curtis Windatt

2011-12-06 17:38:03 EST

Verified using I20111206-1015