Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352804

Summary:	[target] NPE in LoadTargetDefinitionJob#handleReload
Product:	[Eclipse Project] PDE	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	UI	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ankur_sharma, curtis.windatt.public, daniel_megert, nicolas.bros
Version:	3.6.2	Flags:	ankur_sharma: review+
Target Milestone:	3.7.1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	347668
Bug Blocks:

Description Curtis Windatt

2011-07-21 16:59:14 EDT

+++ This bug was initially created as a clone of Bug #347668 +++

Cloned to apply the fix to 3.7.1

I opened a target platform editor (org.eclipse.pde.internal.ui.editor.targetdefinition.TargetEditor).

I got:
Communication with repository at http://download.eclipse.org/eclipse/updates/3.6/R-3.6-201006080911 failed.
java.net.SocketTimeoutException: Read timed out

And then this NPE from PDE:

java.lang.NullPointerException
at org.eclipse.pde.internal.core.target.provisional.LoadTargetDefinitionJob.handleReload(LoadTargetDefinitionJob.java:375)
at org.eclipse.pde.internal.core.target.provisional.LoadTargetDefinitionJob.loadPlugins(LoadTargetDefinitionJob.java:284)
at org.eclipse.pde.internal.core.target.provisional.LoadTargetDefinitionJob.runInWorkspace(LoadTargetDefinitionJob.java:141)
at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)


Eclipse Platform
Version: 3.6.2
Build id: M20110210-1200

Comment 1 Curtis Windatt

2011-08-11 17:21:43 EDT

Released to 3.7.1

Comment 2 Curtis Windatt

2011-08-17 09:38:30 EDT

As per http://www.eclipse.org/eclipse/development/plans/freeze_plan_3_7_1.php
this bug needs a review+ on the patch from another committer and a review+ from
a component lead to be committed into 3.7.1.

Comment 3 Curtis Windatt

2011-08-17 09:39:42 EDT

Ankur and Dani, would you please review the fix.

Comment 4 Ankur Sharma

2011-08-17 14:24:58 EDT

+1

Comment 5 Curtis Windatt

2011-08-18 17:16:05 EDT

Fix is released for 3.7.1.  Ankur's review satisfies the SR1 freeze requirements.

Comment 6 Dani Megert

2011-08-19 04:27:22 EDT

The fix looks good, but you need to increase the bundle version to 3.4.200.qualifier.

Comment 7 Dani Megert

2011-08-19 04:28:17 EDT

(In reply to comment #6)
> The fix looks good, but you need to increase the bundle version to
> 3.4.200.qualifier.

3.4.201.qualifier that is.

Comment 8 Dani Megert

2011-08-19 04:37:44 EDT

'org.eclipse.pde.core' also needs its version fixed.

Comment 9 Dani Megert

2011-08-19 04:52:29 EDT

I've fixed the versions in R3_7_maintenance so that we catch the Git bus.

Comment 10 Curtis Windatt

2011-09-01 15:25:03 EDT

I haven't been able to reproduce while working with targets, but the fix is in 3.7.1 and corrects the potential NPE.  Marking as VERIFIED.