Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352800

Summary:

[ftp] Empty listing when connecting a WFTPD server on Windows

Product:

[Tools] Target Management

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

RSE

Assignee:

Martin Oberhuber <mober.at+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

eclipse-bugzilla, kitlo, xuanchen

Version:

3.2.2

Keywords:

PII

Target Milestone:

3.3.1

Flags:

xuanchen: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch v1	none

Description Martin Oberhuber

2011-07-21 15:21:09 EDT

+++ This bug was initially created as a clone of Bug #253972 +++

Build ID: RSE 3.2.2
CQ:WIND00258337

Connecting a WFTPD Server always returns an empty list in RSE.

Reason is that WFTPD sends UNIX style listings, but doesn't accept the "-a" listCommandModifier, therefore it cannot be parsed with any default RSE parser.
This is related to bug 253972 but not the same.
Here is a sample session on commanline:

Y:\>ftp localhost
Connected to foo-bar.yoyo.com.
220 WFTPD 2.0 service (by Texas Imperial Software) ready for new user
User (foo-bar.yoyo.com:(none)): master
331 Give me your password, please
Password:
230 Logged in successfully
ftp> quote syst
215 MSDOS A N (WFTPD by Texas Imperial Software)
ftp> ls -a
200 PORT command okay
150 File Listing Follows in ASCII mode
226 Transfer finished successfully.
ftp> ls
200 PORT command okay
150 File Listing Follows in ASCII mode
PerfLogs
Program Files
Users
226 Transfer finished successfully.
ftp: 198 bytes received in 0.00Seconds 66.00Kbytes/sec.
ftp> dir
200 PORT command okay
150 File Listing Follows in ASCII mode
-rwxrwxrwx   1 noone    nogroup      431 Mar 29 14:42 .bash_history
drwxrwxrwx   1 noone    nogroup        0 Jul 14  2009 PerfLogs
dr-xr-xr-x   1 noone    nogroup        0 Mar  1 13:03 Program Files
dr-xr-xr-x   1 noone    nogroup        0 Jan 31 20:08 Users
226 Transfer finished successfully.
ftp: 1191 bytes received in 0.01Seconds 91.62Kbytes/sec.
ftp>

Comment 1 Martin Oberhuber

2011-07-21 15:24:43 EDT

Created attachment 200118 [details]
patch v1

This patch adds a listing parser for WFTPD - which is same as the UNIX parser but without the "-a" list command modifier. 

I think the fix is safe because of the narrow matching REGEX.

The fix does introduce PII but I don't think this is relevant here sine I'm not aware of any place where that PII is actually shown in the UI (the connection properties always show the parser ID, not the label.

Comment 2 Martin Oberhuber

2011-07-21 15:26:26 EDT

Xuan can you check whether adding that PII in the patch is acceptable for 3.3.1 ?

Comment 3 Xuan Chen

2011-07-21 17:02:24 EDT

Martin,
I checked our NL coordinator...  Since this only requires a very small change of PII (I assumed), we should be able to drop it to translation.

The next PII shipment is tomorrow (Friday, July 22).  If you have the driver ready, please let me know.  I will send the link to him.

Otherwise, the last PII drop before TVT is 8/9.  

Thanks.

Comment 4 Martin Oberhuber

2011-07-21 17:14:52 EDT

Thanks Xuan. Released into 3.3.1 as R33x_v201107212114

Comment 5 Xuan Chen

2011-07-22 13:15:52 EDT

Hi Martin,
So this nightly driver:
http://download.eclipse.org/tm/downloads/drops/N20110722-0001/index.php
contains the PII changes?

I need to know which driver I should point to to our NL cooridinator.  Thanks.

Comment 6 Martin Oberhuber

2011-07-22 13:56:55 EDT

Please use this:
http://download.eclipse.org/tm/downloads/drops/I20110722-1330/index.php

I don't know why the autobuild didn't run yesterday, so I just kicked a build today.

Comment 7 Xuan Chen

2011-07-22 15:50:46 EDT

I clicked on the link for main eclipse download on this page:
http://www.eclipse.org/downloads/download.php?file=/tm/downloads/drops/I20110722-1330/RSE-runtime-I20110722-1330.zip

But I got "not found" error  (my browser automatically takes me to the fullmoon mirror site.).  I guess the copy to fullmoon server failed (I got similar problem before).

Kit, can you access to those zip files?  That is the driver to be used by the PII drop.  

Thanks.

Comment 8 Martin Oberhuber

2011-07-22 17:37:41 EDT

The URL works for me, perhaps you can get it without redirection:
http://download.eclipse.org/tm/downloads/drops/I20110722-1330/RSE-runtime-I20110722-1330.zip