Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352788

Summary:	Expression,Variable,Register value column no longer shows 'Error: ...' when getFormattedExpressionValue fails.
Product:	[Tools] CDT	Reporter:	Winnie Lai <wlai>
Component:	cdt-debug-dsf	Assignee:	Project Inbox <cdt-debug-dsf-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:	Pawel Piech <pawel.1.piech>
Severity:	normal
Priority:	P3	CC:	cdtdoug
Version:	8.0
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Winnie Lai

2011-07-21 13:07:34 EDT

Build Identifier: 3.7  I20110613-1736

In registers/variables/expression view, value cell is blank when the service's getFormattedExpressionValue() returns with a failed request status. This happens in eclipse 3.7 but not 3.6. In 3.6, the value cell shows the error message in red foregrond like Error: xxx

When FormattedValueRetriever calls IFormattedValues.getFormattedExpressionValue() fails, FormattedValueRetriever only puts the returned status into the given IPropertiesUpdate object. It needs to put the status to the IPropertiesUpdate object's property-status map with property IDebugVMConstants.PROP_FORMATTED_VALUE_ACTIVE_FORMAT_VALUE.

This is required because AbstractCachingVMProvider's updateNode() uses PropertiesUpdateStatus's mergePropertiesStatus() to merge status, and the latter method checks the status for a given property. If there is no status for the property, the merge method will ignore it although the properties status object itself has status message and has severity != ok.
This makes AbstractCachingVMProvider finally lose the non-ok status. This then make org.eclipse.cdt.dsf.debug.ui.viewmodel.ErrorLabelText and ErrorLabelForeground fails to become active.




Reproducible: Always

Comment 1 Pawel Piech

2011-07-21 13:43:25 EDT

I believe this is the same bug as not reporting errors in expressions view.  Please correct me if I'm wrong.

*** This bug has been marked as a duplicate of bug 351898 ***

Comment 2 Winnie Lai

2011-07-21 14:21:13 EDT

Pawel,
This is not same as bug 351898.

The fix of 35198 does not help to fix Bug 352788. The reason is patch of 351898 assumes failure comes from service.getExpressionData. 

The root cause of this bug 352788 is FormattedValueRetriever does not propagate the status proeprly when getFormattedExpressionValue fails. This affects all views using FormattedValueRetriever. In my case, my register name is valid, nothing deal with VariableNode and getExpressionData. In my another case, I have a valid expression that does not fail getExpressionData and only fails getFormattedExpressionValue().

Comment 3 Pawel Piech

2011-07-21 14:52:21 EDT

(In reply to comment #2)
Hi Winnie, did you also consider the changes in bug 351898 comment#2.  Unfortunately I hadn't produced a patch prior to committing that one.

Comment 4 Winnie Lai

2011-07-21 15:34:57 EDT

(In reply to comment #3)
> (In reply to comment #2)
> Hi Winnie, did you also consider the changes in bug 351898 comment#2. 
> Unfortunately I hadn't produced a patch prior to committing that one.

I did not see there is a change to PropertiesUpdateStatus. Just quickly try the code and I see this bug is addressed. In my case, I don't need the change in VariableVMNode.

Please mark this bug properly. Thanks.

Comment 5 Pawel Piech

2011-07-21 16:33:07 EDT

Marking back as duplicate after clarification.

*** This bug has been marked as a duplicate of bug 351898 ***