Bugzilla – Full Text Bug Listing
| Summary: | Null pointer exception when press F2 on an expression in expression view without columns | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Winnie Lai <wlai> | ||||
| Component: | Debug | Assignee: | Pawel Piech <pawel.1.piech> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cdtdoug, Michael_Rennie, pawel.1.piech | ||||
| Version: | 3.7 | Flags: | Michael_Rennie:
review+
|
||||
| Target Milestone: | 3.7.1 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Winnie Lai
*** Bug 352783 has been marked as a duplicate of this bug. *** Created attachment 200111 [details]
Fix.
This fix gets rid of both exceptions. We still have the problem in that in DSF, in that F2 does not activate in-line editing, instead it opens a dialog. I'll file a separate bug for that.
I'd like to target this for SR1. Mike, could you review the changes? (In reply to comment #2) > Created attachment 200111 [details] > Fix. > This fix gets rid of both exceptions. We still have the problem in that in > DSF, in that F2 does not activate in-line editing, instead it opens a dialog. > I'll file a separate bug for that. I would think one possible solution for getting F2 to work is to make IDebugVMConstants.COLUMN_ID__EXPRESSION to have value of VariableColumnPresentation.COLUMN_VARIABLE_NAME, instead of its own value DsfUIPlugin.PLUGIN_ID + ".COLUMN_ID__EXPRESSION". This allows us to reuse the same code from org.eclipse.debug.ui. This is better than duplicating the same code into dsf debug ui. You may have other opinions of doing so. (In reply to comment #4) > I would think one possible solution for getting F2 to work is to make > IDebugVMConstants.COLUMN_ID__EXPRESSION to have value of > VariableColumnPresentation.COLUMN_VARIABLE_NAME, instead of its own value ... I agree, see bug 352795. I would like to move COLUMN_VARIABLE_NAME to IDebugUIConstants also, but since we're considering to promote all flex hierarchy API in 3.8 (bug 161435), I think it's be better to wait. (In reply to comment #5) > (In reply to comment #4) > > I would think one possible solution for getting F2 to work is to make > > IDebugVMConstants.COLUMN_ID__EXPRESSION to have value of > > VariableColumnPresentation.COLUMN_VARIABLE_NAME, instead of its own value > ... > I agree, see bug 352795. I would like to move COLUMN_VARIABLE_NAME to > IDebugUIConstants also, but since we're considering to promote all flex > hierarchy API in 3.8 (bug 161435), I think it's be better to wait. (In reply to comment #5) > (In reply to comment #4) > > I would think one possible solution for getting F2 to work is to make > > IDebugVMConstants.COLUMN_ID__EXPRESSION to have value of > > VariableColumnPresentation.COLUMN_VARIABLE_NAME, instead of its own value > ... > I agree, see bug 352795. I would like to move COLUMN_VARIABLE_NAME to > IDebugUIConstants also, but since we're considering to promote all flex > hierarchy API in 3.8 (bug 161435), I think it's be better to wait. Great. Eventually, I think IDebugVMConstants.COLUMN_ID__TYPE and COLUMN_ID__VALUE will map to the corresponding entries in VariableColumnPresentation, if someone adds funtionality for the type and the value columns in the future that we just want to get it without copying the code. I will ping Patrick to review the patch of 352795. The patch looks good. Also my +1 for 3.7.1. Applied patch to HEAD and 3.7.1 |