Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352626

Summary:	Move platform debug to Java 1.6 BREE
Product:	[Eclipse Project] Platform	Reporter:	Michael Rennie <Michael_Rennie>
Component:	Debug	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public, daniel_megert, david_williams, ed, jdsalingerjr, markus.kell.r, pawel.1.piech, pwebster, remy.suen
Version:	3.7
Target Milestone:	4.4 M1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	352479, 409456, 413095, 414020, 414029, 414030
Bug Blocks:

Description Michael Rennie

2011-07-20 12:19:18 EDT

+++ This bug was initially created as a clone of Bug #352479 +++

It would be nice to move platform debug to a 1.5 BREE. Aside from the obvious language benefits, it would be good to keep its BREE in sync with JDT debug.

Pawel, your thoughts? 

If we were to do this work it would be good to do prior to the promotion of the async viewer code to official API - that way the APIs would not have to modified after-the-fact.

Comment 1 Pawel Piech

2011-07-20 14:08:36 EDT

I'm in favor for moving to 1.5, I only need to make sure that I'll have time to refactor the code.

Comment 2 Dani Megert

2012-07-31 01:46:56 EDT

*** Bug 386277 has been marked as a duplicate of this bug. ***

Comment 3 Dani Megert

2012-07-31 01:47:52 EDT

Two notes on this:

1. The minimum execution environment should not be changed (especially raised)
   unless we have a need for it, e.g. there's a new API without which we can't
   do the job.

2. When moving to 1.5 or higher one must also generify the code, which involves
   work (see: http://wiki.eclipse.org/Generify_A_Java_Project ).

Comment 4 Joseph Carroll

2012-07-31 10:25:19 EDT

Dani-

Thanks for pointing this out to me, I did a quick search last night but obviously not enough.

I read through the Generify [1] and Evolving API's [2] wikis and have two quick comments/questions:

   1) By raising the execution environment, does that necessitate generify'ing the project?  Or, can the execution environment be raised independently?

   2) Do(/how) the following preferences effect binary compatibility?  I can certainly conjecture from their names what the impact may well be.  However, in the sense of updating the execution environment, if you only update the classpath and manifest, where do these settings factor in?
    -org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=disabled
    -org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.2
    -org.eclipse.jdt.core.compiler.compliance=1.4
    -org.eclipse.jdt.core.compiler.source=1.3
    -(others?)

Thanks,

JD

[1] http://wiki.eclipse.org/Generify_A_Java_Project
[2] http://wiki.eclipse.org/Evolving_Java-based_APIs

Comment 5 Dani Megert

2012-07-31 11:03:42 EDT

(In reply to comment #4)
> Dani-
> 
> Thanks for pointing this out to me, I did a quick search last night but
> obviously not enough.
> 
> I read through the Generify [1] and Evolving API's [2] wikis and have two
> quick comments/questions:
> 
>    1) By raising the execution environment, does that necessitate
> generify'ing the project?  Or, can the execution environment be raised
> independently?

When moving away from 1.4 one of the main benefits are Generics. That alone would be a good reason to raise it. So, yes, this should be seen as a must.

> 
>    2) Do(/how) the following preferences effect binary compatibility?  I can
> certainly conjecture from their names what the impact may well be.  However,
> in the sense of updating the execution environment, if you only update the
> classpath and manifest, where do these settings factor in?
>     -org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=disabled
>     -org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.2
>     -org.eclipse.jdt.core.compiler.compliance=1.4
>     -org.eclipse.jdt.core.compiler.source=1.3
>     -(others?)
> 
One would only change the EE, which would imply those settings. The immediate breakage happens because users can no longer use Debug with a 1.4 JRE even though it would work, but the bundle will fail to load (satisfy the constraint).

Comment 6 Michael Rennie

2013-07-31 12:47:34 EDT

Pushed to master:

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=d975f27f12707ae6598994c5e3c6bd5e271d46c4

I'll leave the bug open until we have a build.

Comment 7 Michael Rennie

2013-08-06 13:50:46 EDT

We have a build, marking fixed. Any new issues can be opened in their own bug reports.

Comment 8 Ed Willink

2013-11-27 10:04:14 EST

(In reply to Michael Rennie from comment #7)
> We have a build, marking fixed. Any new issues can be opened in their own
> bug reports.

Bug 422048.