| Summary: | Build is failing due to several red tests | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Benjamin Muskalla <b.muskalla> |
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | daniel_megert, dariusz.luksza, matthias.sohn, robin.rosenberg |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Benjamin Muskalla
Synchronize view tests are failing because of bug 231905. Personally I don't have any idea how this can be fixed. Is the GitRepositoriesViewTest.testShowProperties test failing for anyone locally? It passes locally for me. Can those tests either be fixed or disabled for now? It is very frustrating if one submits a patch and then gets a -1 from Hudson due to this unrelated test failure. I now got this [1] two times on two different patches. If tests like this stay in the test suite, then one cannot trust the Hudson result anymore. Also, for new contributors it is not only frustrating but also results in wasted time when trying to figure out why the own patch caused test failures. [1] Timeout after: 15000 ms.: null org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 15000 ms.: null at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:398) at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:372) at org.eclipse.egit.ui.test.TestUtil.waitUntilTreeHasNodeContainsText(TestUtil.java:212) at org.eclipse.egit.ui.view.synchronize.AbstractSynchronizeViewTest.waitForNodeWithText(AbstractSynchronizeViewTest.java:267) at org.eclipse.egit.ui.view.synchronize.SynchronizeViewGitChangeSetModelTest.shouldSynchronizeInEmptyRepository(SynchronizeViewGitChangeSetModelTest.java:171) (In reply to comment #3) > Can those tests either be fixed or disabled for now? It is very frustrating > if one submits a patch and then gets a -1 from Hudson due to this unrelated > test failure. I now got this [1] two times on two different patches. If > tests like this stay in the test suite, then one cannot trust the Hudson > result anymore. > > Also, for new contributors it is not only frustrating but also results in > wasted time when trying to figure out why the own patch caused test failures. > > > [1] > Timeout after: 15000 ms.: null > > org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 15000 > ms.: null > at > org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:398) > at > org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:372) > at > org.eclipse.egit.ui.test.TestUtil.waitUntilTreeHasNodeContainsText(TestUtil. > java:212) > at > org.eclipse.egit.ui.view.synchronize.AbstractSynchronizeViewTest. > waitForNodeWithText(AbstractSynchronizeViewTest.java:267) > at > org.eclipse.egit.ui.view.synchronize.SynchronizeViewGitChangeSetModelTest. > shouldSynchronizeInEmptyRepository(SynchronizeViewGitChangeSetModelTest.java: > 171) see bug 371633 The tests seems to be stable now, in particular this one. |