Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352497

Summary: Remove log message form Scope#getConstructor
Product: [WebTools] JSDT Reporter: Ian Tewksbury <itewksbu>
Component: GeneralAssignee: Ian Tewksbury <itewksbu>
Status: RESOLVED WONTFIX QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: cmjaun
Version: 3.2.5   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix Patch none

Description Ian Tewksbury CLA 2011-07-19 14:44:29 EDT 
I placed a log message in Scope#getConstructor in Bug 306958.  This log message fires any time more then one constructor is found for a given type.  I did not think this scenario was possible but I put in the log message just in case.  Turns out it is very possible and happens very often flooding the log with messages.

The log message should be removed and a new bug opened to figure out why there are more then one constructor for type and if it is legal.  Then if it is a legal situation what to do about it.
Comment 1 Ian Tewksbury CLA 2011-07-19 14:45:18 EDT 
Created attachment 199932 [details]
Fix Patch

Patch to remove log message.
Comment 2 Chris Jaun CLA 2011-07-19 14:47:35 EDT 
Shouldn't we figure out why there are multiple constructors?
Comment 3 Ian Tewksbury CLA 2011-07-19 14:48:00 EDT 
I opened bug 352498 to determine why there is more then on constructor and if it is a legal case or not.
Comment 4 Ian Tewksbury CLA 2011-07-19 14:49:12 EDT 
(In reply to comment #2)
> Shouldn't we figure out why there are multiple constructors?

Separate bug.  Now that we know this is a problem we should turn off the log message and determine what to do from here.  From a quick chat with Nitin he thinks this maybe legal.  But if it is then some things need to be changed around to handle it.  Such as Scope#getConstructor which is designed to only return one constructor.
Comment 5 Nitin Dahyabhai CLA 2011-09-15 13:26:16 EDT 
I think it's a good diagnostic to have around.  When we figure out the root cause, will reconsider applying.